Skip to content

Move the test suites to bats-core - #108

Merged
AndrewSav merged 1 commit into
mailserver2:masterfrom
AndrewSav:update-bats-core
Nov 18, 2026
Merged

AndrewSav merged 1 commit into
mailserver2:masterfrom
AndrewSav:update-bats-core

Conversation

@AndrewSav

Copy link
Copy Markdown
Collaborator

Closes #96

Description

Updating test framework from upstream.

Fixes #96

  • What is the current behavior (you can also link to an open issue here) ?
    sstephenson/bats is archived. The submodules now point at bats-core: bats-core v1.14.0, bats-assert v2.2.4, and bats-support at master 787ac47. bats-support's only release, v0.3.0, is the 2016 commit the old ztombol submodule already used; master adds four small fixes since.
  • What is the new behavior (if this is a feature change) ?
    bats-core refuses a file with duplicate test names. ldap.bats had two pairs ("delivers mail to existing forward/alias"), and bats 0.4.0 ran the later body of each twice, so the john.doe checks never ran. They are now named by recipient and pass.
    CONTRIBUTING.md pointed at test/tests.bats and the old hardware/mailserver issues page; both now point at what exists.

Type of change

  • Test (adding missing tests or correcting existing ones)

Status

  • Ready

Todo List

  • Implementation
  • Tests

How has this been tested ?

  • All 9 suites pass, 361/361, with the same per-suite counts as master.

sstephenson/bats is archived. The submodules now point at bats-core:
bats-core v1.14.0, bats-assert v2.2.4, and bats-support at master
787ac47. bats-support's only release, v0.3.0, is the 2016 commit the
old ztombol submodule already used; master adds four small fixes since.

bats-core refuses a file with duplicate test names. ldap.bats had two
pairs ("delivers mail to existing forward/alias"), and bats 0.4.0 ran
the later body of each twice, so the john.doe checks never ran. They
are now named by recipient and pass.

CONTRIBUTING.md pointed at test/tests.bats and the old hardware/mailserver
issues page; both now point at what exists.

All 9 suites pass, 361/361, with the same per-suite counts as master.

Closes mailserver2#96
@AndrewSav
AndrewSav merged commit 1f66fe0 into mailserver2:master Nov 18, 2026
9 checks passed
@AndrewSav
AndrewSav deleted the update-bats-core branch November 18, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consider updating bats if practical

2 participants