Repository navigation
feat(steward): refine stalled PR signal clock, author-reply bypass, and bucket wakeups - #9207
Open
loopx-agent wants to merge 1 commit into
Open
loopx-agent wants to merge 1 commit into
loopx-agent wants to merge 1 commit into
Conversation
…nd bucket wakeups Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
动机 / Motivation
Scoped Steward PR monitors previously evaluated
min_stalled_hoursagainst rawitem.updatedAtand recorded onlystalled_threshold_met: true, which caused Mergify/bot comments to reset the stall clock, hid external contributor replies awaiting maintainer answers, and prevented bucket-crossing wakeups at 72h / 7d.改动思路 / Approach
Extract an exact-head
REQUEST_CHANGESstall clock (stalled_since) and non-bot author-reply state ingithub_pr_evidence.py, then classifystalled_bucketand stabilizeobserveStewardSignalMonitorhashes insteward_managed_mode.tswithawaiting_maintainer_replypriority for external PRs.具体改动 / Changes
loopx/capabilities/native_chat/github_pr_evidence.py: extend_GITHUB_OPEN_PRS_GRAPHQL_QUERYand_normalize_graphql_pr_nodewithcomments(last: 20)and head commitoid,committedDate,pushedDate; add_summarize_request_changes_stallto emitstalled_since,author_replied_after_request_changes, andlatest_request_changes_review_idwhile ignoring bots and stale-commit reviews.loopx/control_plane/collaboration/steward_managed_mode.ts: updatefilterScopedRepositoryItemsandclassifyStalledBucketto computestalled_bucket(awaiting_maintainer_reply|24h_to_72h|72h_plus|7d_plus), allow immediateawaiting_maintainer_replyinclusion underauthor_mode: "exclude", drop stale-commitREQUEST_CHANGESitems when scoped toREQUEST_CHANGES, and excludeupdatedAtfromobserveStewardSignalMonitorhash inputs whenstalled_sinceis present.loopx/capabilities/native_chat/steward_turn.py: document the projected stall clock and bucket fields in the advancement instruction string.tests/control_plane_ts/steward_managed_mode.test.ts&tests/test_steward_pr_merge_and_review_signal.py: add unit coverage for botupdatedAtbumps, external author replies vs maintainer replies, stale-commit exclusion, and 24h/72h/7d bucket wakeups.验证 / Verification
node --test tests/control_plane_ts/steward_managed_mode.test.ts: 17 passed, 0 failedpytest -n 4 tests/test_steward_pr_merge_and_review_signal.py tests/test_steward_generic_monitor_todo.py -q: 15 passedpytest -n 4 tests/test_lark_steward_reports.py -q: 30 passedruff check: All checks passedmypy: Success: no issues found in 17 source filesloopx check --scan-path .:ok=True, 0 errorsloopx canary premerge --tier quick --from-git-diff --git-diff-base origin/main: passed (3/3 catalog canaries)对主干的风险 / Risks
Low risk: preserves
signal_scope: nullfeature-off parity and falls back toupdatedAtonly whenstalled_sinceis absent. Leaves protected PR merge behind independent exact-head review.