Repository navigation
[v5] Name machines by their display name in the web UI - #646
Merged
Merged
Conversation
ldionne
force-pushed
the
v5-machine-display-name-client
branch
from
November 4, 2026 09:58
1e06bd5 to
cc12076
Compare
Name a machine by its label, its display name when it has one and its name otherwise, wherever the web UI shows it (AR23, a new section modelled on AR22). Links, URLs, requests, the text typed to confirm a deletion and the rename prompt keep using names. - Unlike a suite's, a machine's name stays in view where the user finds a machine among others: pickers and the Machines tab show a machine with a display name by its label followed by its name, muted, since the name is what bots, command lines and URLs know it by, and display names are not unique. Pickers also find a machine, and Enter picks it, by its name. - Machines are ordered by label, as suites are, and client-side machine filters match the label or the name. - Responses that name a machine (runs, indicators, trends) carry its name alone (I4), so `useMachineLabels` looks the labels up in the suite's machine list, the same cached query the pickers use, falling back to the name, silently, while it loads or if it fails. Series, traces, chips and maps stay keyed by name, so two machines sharing a label stay apart. - Machine Detail names the machine by its label in its heading and edits its display name in place; emptying the input clears it. - The seed gives two synthetic machines a display name, one with a '/'. Page sections of the spec change only where they would contradict AR23: AR14, AR18, TS1, TS3, DT1, DT3, GR1, GR10 and DA2. Fixes llvm#599.
ldionne
force-pushed
the
v5-machine-display-name-client
branch
from
November 4, 2026 12:29
cc12076 to
0e717a0
Compare
ldionne
enabled auto-merge (squash)
November 4, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name a machine by its label (its display name when it has one, its name otherwise) wherever the web UI shows it, per a new AR23 "Machines" section modelled on AR22. Links, URLs, API requests, the text typed to confirm a deletion and the rename prompt keep using names.
useMachineLabels(suite)looks labels up in the suite's machine list (the same cached query the pickers use), falling back silently to the name while it loads or if it fails. Series, traces, chips and maps stay keyed by name; tests check that two machines with the same label stay apart (Graph traces and baselines, sparklines, pickers)./.Tested:
npm run check,npm run test:e2e(with a new test on a suite of its own: setting a display name with a/on Machine Detail, then seeing it on the Machines tab, the Runs tab and the Graph's picker, and clearing it).Fixes #599.