Skip to content

Problems says what is wrong, hover details by setting, a tab for showView - #203

Merged
CatarinaGamboa merged 2 commits into
mainfrom
problems-headline
Nov 12, 2026
Merged

CatarinaGamboa merged 2 commits into
mainfrom
problems-headline

Conversation

@CatarinaGamboa

@CatarinaGamboa CatarinaGamboa commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Three changes asked for by the error-message study's first pilot (2026-11-12).

The Problems entry says what is wrong. It was the title alone ("State Refinement Error"), so the Problems tab said which kind of error there was and not what. The language server now sends the title and the headline as plain text, e.g. State Refinement Error: kettle.boil() needs .... VS Code shows that text in the Problems tab and in its own part of the hover, so the extension's part of the hover no longer repeats the headline: it shows the details only (the origin notes, the counterexample, the hints).

liquidjava.hover.showDetails replaces liquidjava.hover.showHints of 0.1.1. Off, the hover is the message alone and every detail is in the LiquidJava view (where the hints stay closed until opened). A hover that named the hints without showing them, which 0.1.1 did, was neither one thing nor the other.

liquidjava.showView(diagnostic?, tab?, from?). Without a diagnostic and with a tab, the command opens that tab of the view (the study's tour opens the State Machine tab this way). from names the caller in the usage log; the code lenses stay the default.

Tests: the server test pins the new Problems text; the markdown spec pins the hover's part without the headline; the webview spec covers the selectTab message. Lint, type checks and the unit tests pass.

🤖 Generated with Claude Code

Screenshots (study build, 0.1.2)

The Problems entry with the headline:

Problems with the headline

The hover with liquidjava.hover.showDetails off, the message alone; the details stay in the view:

Hover, message only

CatarinaGamboa and others added 2 commits November 12, 2026 02:11
…b for the showView command

The Problems entry of an error was its title alone ("State Refinement Error"), so the list said
which kind of error there was and not what was wrong. The language server now sends the title and
the headline, as plain text; the extension's part of the hover no longer repeats the headline and
shows the details only: the origin notes, the counterexample and the hints.

liquidjava.hover.showDetails replaces liquidjava.hover.showHints (0.1.1): off, the hover is the
message alone and every detail is in the LiquidJava view. A hover that named the hints without
showing them was neither one thing nor the other.

liquidjava.showView takes a tab without a diagnostic, which opens that tab of the view, and a
third argument naming who asked, for the usage log (the code lenses by default).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
… off

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@CatarinaGamboa

Copy link
Copy Markdown
Collaborator Author

Codex review (codex exec, read-only, on the diff against main), two findings:

  1. High: a tab-only showView call can be lost for a hidden view, because pendingTab is only sent on the webview's ready. Not changed: the view is registered without retainContextWhenHidden, so a hidden view's webview is destroyed and re-resolved when it is shown, and the script posts ready again. That is the path pendingDiagnosticReveal (the code lenses) has used all along; pendingTab follows it.
  2. Medium: a settings file with liquidjava.hover.showHints: false from 0.1.1 would show the details again. Fixed: the hover honours the old key when it is set to false (one line in hover.ts).

Clean-code pass: the two pending fields (pendingDiagnosticReveal, pendingTab) are the same pattern twice; a queue of pending messages drained on ready would be the one abstraction. Left as is: two fields read more plainly than a queue for two cases, and nothing else is pending.

@CatarinaGamboa
CatarinaGamboa merged commit 27f8457 into main Nov 12, 2026
3 checks passed
@CatarinaGamboa
CatarinaGamboa deleted the problems-headline branch November 12, 2026 02:17
@CatarinaGamboa CatarinaGamboa mentioned this pull request Nov 12, 2026
CatarinaGamboa added a commit that referenced this pull request Nov 12, 2026
Version bump for 0.1.2: the Problems entries say what is wrong,
`liquidjava.hover.showDetails` (replacing `showHints`), and
`liquidjava.showView` with a tab and a caller (#203).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
CatarinaGamboa added a commit that referenced this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant