Skip to content

warpinator-send-check: Use gdbus instead of Python - #267

Open
SeniorMatt wants to merge 1 commit into
linuxmint:masterfrom
SeniorMatt:fast-send-check
Open

SeniorMatt wants to merge 1 commit into
linuxmint:masterfrom
SeniorMatt:fast-send-check

Conversation

@SeniorMatt

Copy link
Copy Markdown

Nemo runs warpinator-send-check synchronously on every right-click on a file or folder, before it shows the menu. Starting Python and importing gi took most of a second on my laptop in power-saver mode; perf of Nemo during right-clicks showed about half the samples in Python startup. Same symptom as #198, different cause.

This does the same two checks (is Warpinator running, does it have remotes) with gdbus instead, which takes a few milliseconds. libglib2.0-bin is added to Depends for gdbus.

Tested on Mint 27: right-clicks in Nemo are instant again. Also checked against a mock org.x.Warpinator with 0 and 2 remotes and with no service running.

Nemo runs this condition synchronously on every right-click on a file
or folder, before it shows the context menu. Starting Python and
importing gi takes most of a second on a laptop in power-saver mode,
so every right-click froze Nemo for that long.

Do the same two checks (is Warpinator running, does it have remotes)
with gdbus, which takes a few milliseconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant