Repository navigation
warpinator-send-check: Use gdbus instead of Python - #267
Open
SeniorMatt wants to merge 1 commit into
Open
SeniorMatt wants to merge 1 commit into
SeniorMatt wants to merge 1 commit into
Conversation
Nemo runs this condition synchronously on every right-click on a file or folder, before it shows the context menu. Starting Python and importing gi takes most of a second on a laptop in power-saver mode, so every right-click froze Nemo for that long. Do the same two checks (is Warpinator running, does it have remotes) with gdbus, which takes a few milliseconds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nemo runs
warpinator-send-checksynchronously on every right-click on a file or folder, before it shows the menu. Starting Python and importing gi took most of a second on my laptop in power-saver mode; perf of Nemo during right-clicks showed about half the samples in Python startup. Same symptom as #198, different cause.This does the same two checks (is Warpinator running, does it have remotes) with
gdbusinstead, which takes a few milliseconds.libglib2.0-binis added to Depends for gdbus.Tested on Mint 27: right-clicks in Nemo are instant again. Also checked against a mock
org.x.Warpinatorwith 0 and 2 remotes and with no service running.