Repository navigation
Conversation
Without a metainfo file, AppStream generators build the component from nemo.desktop and the package description; this is deprecated and Debian already reports it as a warning (no-metainfo). The file is generated by generate_additional_file from data/nemo.metainfo.xml.in, like nemo.xml from nemo.xml.in: each <_tag> line of the template is expanded with additionalfiles.write_translated_element(). The summary reuses the already translated "Access and organize files" string of nemo.desktop. The generated file is committed here without translations, they are added on the next regeneration. The component ID stays nemo.desktop, the one generators use today, so existing catalog entries keep working. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
Contributor
Author
|
fails of lmde7 CI seems related to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nemo has no AppStream metainfo file, so generators build its component from
nemo.desktopand the distribution package description. This fallback is deprecated, and the Debian AppStream generator already reports it as a warning (no-metainfo): without metainfo, the application may disappear from software centers in the future.This PR adds
data/nemo.metainfo.xmland installs it inshare/metainfo. The Debian packaging installs it in thenemopackage, anddebian/copyrightdocuments its CC0-1.0 license (themetadata_licenseof the file).To keep the summary translated, the file is generated by
generate_additional_filefrom the templatedata/nemo.metainfo.xml.in, likenemo.xmlfromnemo.xml.in: each<_tag>line of the template is expanded withadditionalfiles.write_translated_element(), so manual changes go in the template. The<_summary>is "Access and organize files", the same string as theCommentofnemo.desktop, so it is already translated and its msgid is already extracted bymakepot(the template is not added there: with the AppStream ITS rules, xgettext would also extract the name and the description paragraphs, which are not translated for now). The generated file is committed here without translations, they are added on the next regeneration.Tested with AppStream 1.2.3 (Debian sid):
appstreamcli validatereports onlycid-desktopapp-is-not-rdns(warning)appstreamcli composeon an installed tree gives the expected component (categories, keywords and mediatypes are merged fromnemo.desktop), with 61 translated summaries when the file is generated with the current translationsSome choices you may want differently:
nemo.desktop, the ID generators use today, asxreaderandxviewerdo, so existing catalog entries keep working. This is what triggers thecid-desktopapp-is-not-rdnswarning. A reverse-DNS ID (e.g.org.x.Nemo) would remove it without renamingnemo.desktop(it stays linked through<launchable>), adding<replaces><id>nemo.desktop</id></replaces>for continuity. Renaming the.desktopfile too is suggested by the validator but would affect MIME defaults and other references, so I did not touch it.Nemoinstead ofFilesfrom the.desktopfile, so it can be told apart from other file managers in software centers.<releases>section, to avoid updating the file on every release.nemo.desktop).