Skip to content

workspace: don't abort when a window is already in the MRU list - #898

Open
octaviofilipepereira wants to merge 1 commit into
linuxmint:masterfrom
octaviofilipepereira:patch-1
Open

octaviofilipepereira wants to merge 1 commit into
linuxmint:masterfrom
octaviofilipepereira:patch-1

Conversation

@octaviofilipepereira

Copy link
Copy Markdown

Cinnamon crashes into fallback mode when some Wine applications are closed and opened again. muffin aborts on the assertion in meta_workspace_add_window():

meta_workspace_add_window: assertion failed: (g_list_find (workspace->mru_list, window) == NULL)

The crash was found and reported by Bráulio Sousa (CT7APZ), a LogBeamOS tester.

How to reproduce (Linux Mint 22.3, muffin 6.6.3+zena, Wine 11.0):

  • Open N1MM Logger+ (amateur radio logging program, .NET under Wine), close it and open it again. Its secondary windows ("GlassPanelForm") trigger the assertion; after a clean start Cinnamon usually crashes on the third reopening.
  • Log4OM (also .NET under Wine) triggers the same crash.

Mutter turned this same assertion into a warning in January 2021 (GNOME/mutter#992, merge request !1692). This change does the same in muffin: g_assert() becomes g_return_if_fail(), so the window is not added twice and the window manager keeps running.

Testing: in a virtual machine with Linux Mint 22.3 and N1MM Logger+, the unpatched muffin crashed twice in 6 to 8 close/reopen cycles (Log4OM: once in 10). With this change, 10 cycles with no crash; the condition happened 6 times and only produced the warning. We have shipped this one-line change in LogBeamOS, a Linux Mint 22.3 based distribution for radio amateurs, since 16/11/2026 (package 6.6.3+zena+logbeamos1).

Same change as mutter (GNOME/mutter#992, merge request !1692): the window is not added twice and the window manager keeps running instead of aborting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant