Repository navigation
workspace: don't abort when a window is already in the MRU list - #898
Open
octaviofilipepereira wants to merge 1 commit into
Open
octaviofilipepereira wants to merge 1 commit into
octaviofilipepereira wants to merge 1 commit into
Conversation
Same change as mutter (GNOME/mutter#992, merge request !1692): the window is not added twice and the window manager keeps running instead of aborting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cinnamon crashes into fallback mode when some Wine applications are closed and opened again. muffin aborts on the assertion in meta_workspace_add_window():
The crash was found and reported by Bráulio Sousa (CT7APZ), a LogBeamOS tester.
How to reproduce (Linux Mint 22.3, muffin 6.6.3+zena, Wine 11.0):
Mutter turned this same assertion into a warning in January 2021 (GNOME/mutter#992, merge request !1692). This change does the same in muffin: g_assert() becomes g_return_if_fail(), so the window is not added twice and the window manager keeps running.
Testing: in a virtual machine with Linux Mint 22.3 and N1MM Logger+, the unpatched muffin crashed twice in 6 to 8 close/reopen cycles (Log4OM: once in 10). With this change, 10 cycles with no crash; the condition happened 6 times and only produced the warning. We have shipped this one-line change in LogBeamOS, a Linux Mint 22.3 based distribution for radio amateurs, since 16/11/2026 (package 6.6.3+zena+logbeamos1).