Repository navigation
Remove direct calls to handle_monitor_update_completion! - #3947
Merged
tnull merged 1 commit intoJul 23, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_monitor_update_completion!(andhandle_monitor_update_completion_actions) are a pretty annoying API as they have several preconditions. Luckily, we already havechannel_monitor_updatewhich does the right work, handling both the open- and closed- channel cases and correctly checking the preconditions tohandle_monitor_update_completion!, so here we convert calls tohandle_monitor_update_completion!(aside fromhandle_new_monitor_update!) to just callingchannelMonitor_update.