Repository navigation
Conversation
…; sqlite_store target unaffected
|
I've assigned @tnull as a reviewer! |
tnull
reviewed
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Downstream wallets that embed LDK together with SQLCipher (e.g. a mobile wallet using
bundled-sqlcipher-vendored-openssl) need exactly onelibsqlite3-sysin the final binary. Cargo'slinks = "sqlite3"rule makes that impossible unless everyrusqlitein the graph resolves to the same sqlite3-sys generation, and arusqlite 0.31(v0.7.x) /rusqlite 0.37(downstream pin) pair cannot co-resolve.Full disclosure:
mainalready loosened the requirement to>=0.31.0, <0.40.0(Cargo.toml:109-110, from #1187), so this is not a hot-fix. It is a backport-willing maintenance contribution so thev0.7.xline can interoperate, together with the two dev-dependency cleanups that arusqlite 0.37resolution exposes.What changed
Branch
sw/rusqlite-0.37, based on tagv0.7.0, 5 commits:aef479a—Cargo.toml:rusqlite 0.31.0 -> 0.37.0(bundledfeature unchanged).17be6be,e02a484—Connection::pragmacall sites:Some(rusqlite::DatabaseName::Main)->Some("main")insrc/io/sqlite_store/migrations.rs(2 sites) andsrc/io/sqlite_store/mod.rs(1 site). rusqlite 0.37 removedDatabaseName; the first parameter is nowschema_name: Option<&str>.26ba14b— drops[target.'cfg(vss_test)'.dev-dependencies] ldk-node-062 = { package = "ldk-node", version = "=0.6.2" }. That dev-dep pulls a secondlibsqlite3-sysinto resolution (not merely the build), which is what breaks downstream unification. It is only used by the cfg-disabled VSS backwards-compat test that needs a live VSS server.d82a50e—[target.'cfg(not(no_download))'.dev-dependencies]:electrsdfeatures reduced to["legacy"], matching the existingcfg(no_download)entry. Theesplora_*/corepc-node_*build scripts download release artifacts and hash-assert them; they panicked on upstream artifact drift here. This is the same effect as running with--cfg no_download, so the integration suites can still run with PATH-provided binaries.Evidence
Downstream gate run (workspace build,
clippy -D warnings,cargo treesingle-copy assertion,cargo denylicenses, SQLCipher cipher test):https://github.com/gdmaster3/SuperWallet/actions/runs/42470100999
Plus this fork's own
cargo test --lib io::sqlite_store— PASS under the bumped pin (the module touched by thepragmachange).Caveats
cfg(vss_test)dev-dep parity: removed rather than re-vendored. If you want it kept, I can re-add it as an explicitly non-default compat path (e.g. a path-patchedldk-node 0.6.2carrying its own rusqlite bump); it should not remain a plain version dependency, since that alone breakslinks = "sqlite3"unification downstream.electrsd/corepc-nodeedit is deliberately inert rather than a version bump: the observed failure was build-script artifact hash drift, not a compile error.Notes for review
release/0.7(this branch is based on tagv0.7.0, so the PR diff is the 5 commits / 3 files).mainalready carries the equivalent modernizations (pragma_update, legacy-onlyelectrsd, noldk-node-062resolution dep), so none of this is needed there.Connection::pragma(Some("main"), ...)is the 0.37 signature (Option<&str>): https://docs.rs/rusqlite/0.37.0/rusqlite/struct.Connection.html#method.pragmaCONTRIBUTING.mdor PR template exists in this repository (only.github/workflows), so no stated title/CLA convention applies; commit messages follow the existingbuild:/ci:prefixes.