Repository navigation
Generate content_kinds from a namedtuple spec - #255
Merged
Merged
Conversation
rtibblesbot
marked this pull request as ready for review
October 31, 2026 00:24
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-184-2f3347
branch
from
November 2, 2026 02:04
8b71ed1 to
97310d4
Compare
rtibbles
approved these changes
Nov 2, 2026
Contributor
Author
|
Quick check on rtibblesbot's work on this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mappingsoption.content_kinds.pyand newjs/ContentKinds.js(default export constants, namedKINDLISTandMAPPINGexports) are generated fromspec/constants-content_kinds.json.kindlookup.jsonremoved; kinds andMAPPINGnow live in one spec.References
Closes #184. Follows #182.
Reviewer guidance
Suggested review: Full code review, then manual QA once the reviewer sets Needs QA.
js/ContentKinds.js.mappings: {NAME: {CONSTANT: [keys]}}spec shape.resources/kindlookup.jsonandcontent_kinds.file_formats, and forMAPPINGnow iterating grouped by kind.js/ContentKinds.jsshould also exportKINDLIST, which the issue did not ask for.make buildon a clean checkout leaves no diff; pinned-API test passes unchanged.MAPPINGformat ids are now string literals in the spec, checked againstfile_formats.FORMATLISTby a test rather than at import.AI usage
Used Claude Code to add the
mappingsgenerator option and migratecontent_kindsto a spec. Verified with the full test suite andmake build.Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
Last updated: 2026-11-02 13:55 UTC