Repository navigation
"contents_sha256: Read archive members in stored order" - #254
Merged
Merged
Conversation
rtibblesbot
marked this pull request as ready for review
October 30, 2026 07:50
rtibbles
approved these changes
Oct 30, 2026
rtibbles
left a comment
rtibbles
left a comment
Member
There was a problem hiding this comment.
Fix is correct and existing tests guarantee the output equivalence of the function.
Reading members in sorted path order seeks backward on every member of an archive stored in another order, refetching a chunk per member through a buffered remote reader such as GCS BlobReader. Closes learningequality#253 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
force-pushed
the
issue-253-890703
branch
from
October 30, 2026 23:52
d593adb to
7bbf24e
Compare
Contributor
Author
|
Quick check on rtibblesbot's work on this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlobReader).References
Closes #253. Consumer: learningequality/infrastructure#940.
Reviewer guidance
Suggested review: This is a low-risk change; it needs a light-touch code review.
Python tests pass on CI.
AI usage
Claude Code implemented the offset-order read and seek-recording test. Verified with the full test suite across local Python versions, archive tests against the previous release, and ruff.
Written by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
Last updated: 2026-10-31 00:38 UTC