Skip to content

Patch for automated testing - #1

Closed
LadySolveig wants to merge 2 commits into
joomla-projects:brunofrom
LadySolveig:patch-for-automated-testing
Closed

LadySolveig wants to merge 2 commits into
joomla-projects:brunofrom
LadySolveig:patch-for-automated-testing

Conversation

@LadySolveig

Copy link
Copy Markdown
Member

Pull Request for Issue #

Summary of Changes

Testing Instructions

Documentation Changes Required

@HermanPeeren

Copy link
Copy Markdown
Collaborator

Hi @renekreijveld and @LadySolveig, thanks for the work on the Bruno collection and the tests!

What we did with the main branch in the repo, and a proposal for the bruno branch.

What's new in this repo

Proposal for the bruno branch

  • The same for Bruno: a generator in main that writes the collection from the spec, a -bruno.zip in each release, and the bruno branch updated automatically. The collection then always matches the spec, including the endpoints that are missing now.
  • The generator makes the file and folder names itself, without spaces, so the renaming in this PR isn't needed.
  • Martina's tests and pre-request data are valuable, and the generator shouldn't overwrite them. My idea: keep them in main per operation, for instance scripts/bruno/tests/<operationId>.js, and let the generator add them to the matching request.

Questions

  1. René: did you make the current collection with a generator, or with Bruno's OpenAPI import? If there's a script, we could start from it.
  2. Martina: would the tests per operation in main work for you? Or do you see a better way to keep them next to a generated collection?

@HermanPeeren

Copy link
Copy Markdown
Collaborator

Closed after discussion on Mattermost and rest of that thread. No need for a separate Bruno collection anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants