Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Let authors keep live spreadsheet calculations inside ordinary document prose.
Closes #133.
What changed
Add editable, bounded grid blocks with raw formulas, number formats, multiple sheets, parent undo/redo and read-only controls. Extract the existing spreadsheet engine for browser/server reuse while preserving its frontend module paths and original test assertions.
Persist independent cell and format keys through Yrs. Keep active sheet, drafts and selection local; retain focused inputs across unrelated edits. Native snapshots preserve source, and HTML/Markdown/DOCX/PDF render computed tables. Schema validation and exports enforce documented size/evaluation limits.
How this was tested
Evidence is retained locally in .ship/evidence-inline-spreadsheet.log. Full Playwright run: https://github.com/jjbaumert/OgreNotes/actions/runs/40799382414
Findings fixed during review
Fix draft persistence on leaving a grid, rejected-draft navigation writing the wrong cell, and cursor restoration after removing a focused workbook. Restore merge predicate grouping, bound INDEX offsets, and implement advertised numeric patterns. Align CI export checks with its intentionally reduced feature set. Follow-up fresh-context reviews have no outstanding findings.
Risk: high
Adds persisted node types and collaborative editing behavior. Existing old browser tabs must be refreshed before editing documents with the new block types. Formula/evaluation limits and export differences are documented in crates/spreadsheet/README.md.