Skip to content

fix: security - vite 7.3.8 (GHSA-p4f5-76q4-ffq7) - #1765

Merged
jaredwray merged 1 commit into
mainfrom
cursor/vite-ghsa-p4f5-76q4-ffq7-d248
Nov 19, 2026
Merged

jaredwray merged 1 commit into
mainfrom
cursor/vite-ghsa-p4f5-76q4-ffq7-d248

Conversation

@jaredwray

Copy link
Copy Markdown
Owner

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Security fix. This change updates the vite pin.

Versions

  • vite 7.3.7 -> 7.3.8

The root pnpm override is the only pin. Vitest 5.0.2 and @vitest/mocker 5.0.2 use that copy. No package depends on vite-plus.

Advisory: GHSA-p4f5-76q4-ffq7

Other paths

These paths do not pin vite:

  • workspace package.json files
  • Docker Compose, the dev container, and GitHub Actions
  • .nvmrc

No vite config sets server.host or --host.

Cooldown

Vite 7.3.8 was published on 2026-11-09. The 7-day cooldown does not block it. This change adds no minimumReleaseAgeExclude entry.

Test audit

This pull request does not add, change, or delete a test. The test audit gate does not apply.

Checks

pnpm install, pnpm build, node scripts/test-build.mjs, and pnpm test:ci passed on Node 22.

Open in Web Open in Cursor 

Move the pnpm override for vite from 7.3.7 to 7.3.8.
Vite 7.3.8 fixes GHSA-p4f5-76q4-ffq7.

Co-authored-by: Jared Wray <me@jaredwray.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T15:10:26.100391Z 1c1db8b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b7611eb) to head (1c1db8b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1765   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         3702      3702           
  Branches       845       832   -13     
=========================================
  Hits          3702      3702           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit a51d2b8 into main Nov 19, 2026
16 checks passed
@jaredwray
jaredwray deleted the cursor/vite-ghsa-p4f5-76q4-ffq7-d248 branch November 19, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants