Repository navigation
Conversation
…nic-framework into FW-6838-ios-sync-snapshots
…os-sync-snapshots # Conflicts: # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Chrome-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Firefox-linux.png # core/src/components/button/test/basic/button.e2e.ts-snapshots/button-diff-ios-rtl-Mobile-Safari-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/clear/button.e2e.ts-snapshots/button-fill-clear-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-ltr-Mobile-Safari-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Chrome-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Firefox-linux.png # core/src/components/button/test/outline/button.e2e.ts-snapshots/button-outline-ios-rtl-Mobile-Safari-linux.png
…os-sync-snapshots # Conflicts: # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/size/button.e2e.ts-snapshots/button-size-ios-ltr-Mobile-Safari-linux.png
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…FW-6838-ios-sync # Conflicts: # core/src/components/back-button/test/toolbar/back-button.e2e.ts-snapshots/back-button-toolbar-ios-ltr-Mobile-Safari-linux.png # core/src/components/back-button/test/toolbar/back-button.e2e.ts-snapshots/back-button-toolbar-ios-rtl-Mobile-Chrome-linux.png # core/src/components/back-button/test/toolbar/back-button.e2e.ts-snapshots/back-button-toolbar-ios-rtl-Mobile-Firefox-linux.png
…os-sync-snapshots
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots
…os-sync-snapshots # Conflicts: # core/src/components/title/test/basic/title.e2e.ts-snapshots/title-basic-ios-ltr-Mobile-Chrome-linux.png
There was a problem hiding this comment.
This shows the month arrows at full blue while everything else is faded, from the disabled arrow issue on #31645. The readonly snapshots have the gray Cancel and Done too, so these datetime files will need regenerating once those are fixed.
There was a problem hiding this comment.
Regenerated in e9e2a50 now that the #31645 fixes are in. The disabled datetime's arrows are gray with the rest, and the readonly buttons are primary again.
In the readonly snapshot, the next month arrow is disabled on purpose: the test sets max to February 20, so there's no March to go to. next disables it too and shows it faded, and here it uses the new ios disabled color.
There was a problem hiding this comment.
About 35 of the files in this PR, like this one, had the same bytes as main before, so their diffs include changes from earlier in the stack and not just the ios sync. They look right, but could you mention that in the PR body so reviewers don't credit them to #31645?
There was a problem hiding this comment.
At 135% the icon gets a bit smaller, 29x29 down to 27x27. The default scale didn't change, so I think it's the new 1.2em icon size, but is that expected?
There was a problem hiding this comment.
Expected. It isn't the 1.2em icon token: an icon-only icon in ion-buttons stays 1.65em of the button font, and this test renders ion-buttons outside a toolbar, so the button uses the default font size, which went from 16px to 15px in the iOS 17 sync (listed in BREAKING.md). That's the same 15/16 ratio as 29px to 27px, and it shows at 100% too. Inside a toolbar the button keeps 17px, so the icon there is unchanged at both scales.
…os-sync-snapshots # Conflicts: # core/src/components/button/test/spinner/button.e2e.ts-snapshots/button-spinner-ios-ltr-Mobile-Chrome-linux.png # core/src/components/button/test/spinner/button.e2e.ts-snapshots/button-spinner-ios-ltr-Mobile-Firefox-linux.png # core/src/components/button/test/spinner/button.e2e.ts-snapshots/button-spinner-ios-ltr-Mobile-Safari-linux.png
Issue number: resolves internal
What is the current behavior?
The ios button snapshots show the button before the iOS 17 sync in #31645.
What is the new behavior?
Updated ios snapshots for #31645: the new label sizes and weight, smaller icons, gray disabled buttons, icon-sized spinners, and filled pressed outline buttons in toolbars.
Does this introduce a breaking change?
Other information
Only ios snapshots change. md and ionic are untouched.
Some of these files matched
mainbefore this round, so their diffs also include changes from the PRs below this one in the stack (#31628 and #31636), not only from #31645.