Skip to content

search: match organization legalName in searchOrganizations - #76

Merged
Kzoeps merged 1 commit into
mainfrom
search/org-legalname
Nov 16, 2026
Merged

Kzoeps merged 1 commit into
mainfrom
search/org-legalname

Conversation

@Kzoeps

@Kzoeps Kzoeps commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Problem
searchOrganizations only matched profile displayName/description, so searching an org by its legal name returned nothing (e.g. "Sınırlı"). This also made the prod smoke fail, since it seeds the term from legalName.

Fix
Also match organization legalName (case-insensitive substring). Orgs without a profile now match on legalName. Lexicon/docs, tests and changeset updated.

Summary by CodeRabbit

  • New Features
    • Organization search now matches legal names as well as profile names and descriptions. Organizations without profiles can also be found by legal name.

Orgs without a profile now match on legalName alone. Updates lexicon
description, docs/skill snapshots, generated Lua/client, tests, changeset.
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-endpoints Ready Ready Preview Nov 16, 2026 8:51am UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 619c9ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hypercerts-org/happyview-modules Minor
@hypercerts-org/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Organization search now matches text against an organization’s legal name and associated profile text. Organizations without profiles can match by legal name. Tests and API descriptions cover the updated search behavior.

Changes: Organization search

Layer / File(s) Summary
Legal-name matching and search documentation
happyview-modules/lua/endpoints/*.lua, happyview-modules/lua/shared/organizationList.lua, happyview-modules/tests/http/actor-organizations.http.test.js, happyview-modules/tests/http/fixtures/actors.fixture.js, happyview-modules/tests/unit/tooling/organization.test.js, happyview-modules/lexicons/*, packages/api/src/lexicons/app/certified/actor/searchOrganizations.defs.ts, docs/openapi.json, docs/sources/lexicons/app.certified.actor.searchOrganizations.json, .agents/skills/hypercerts-api/references/*, .changeset/search-organizations-legal-name.md
Search predicates now include organization legalName alongside profile displayName and description. Tests cover case-insensitive legal-name matches and organizations without profiles. API descriptions and the changeset describe the updated search behavior.

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Bug fix

Suggested reviewers: kristoferlund

Merge Risk: Minimal · up to 619c9

Organization search now also matches legal names, including for organizations without profiles. No concrete merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: organization search via searchOrganizations now matches the organization legalName. The raw summary, PR objectives, lexicon, OpenAPI, Lua endpoint, and test changes al…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: organization search via searchOrganizations now matches the organization legalName. The raw summary, PR objectives, lexicon, OpenAPI, Lua endpoint, and test changes all implement this single change. The title is specific and concise, and it uses the same terms as the code.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4b199649-1693-4073-9213-ffc79b5c26b6
Commits

Reviewing files that changed from the base of the PR and between 4e7caa5 and 619c9ee.

Files selected for processing: 13

  • .agents/skills/hypercerts-api/references/endpoint-map.md
  • .agents/skills/hypercerts-api/references/openapi.json
  • .changeset/search-organizations-legal-name.md
  • docs/openapi.json
  • docs/sources/lexicons/app.certified.actor.searchOrganizations.json
  • happyview-modules/lexicons/app.certified.actor.searchOrganizations.json
  • happyview-modules/lua/endpoints/listOrganizations.lua
  • happyview-modules/lua/endpoints/searchOrganizations.lua
  • happyview-modules/lua/shared/organizationList.lua
  • happyview-modules/tests/http/actor-organizations.http.test.js
  • happyview-modules/tests/http/fixtures/actors.fixture.js
  • happyview-modules/tests/unit/tooling/organization.test.js
  • packages/api/src/lexicons/app/certified/actor/searchOrganizations.defs.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@sonarqubecloud

Copy link
Copy Markdown

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

@Kzoeps
Kzoeps merged commit 33375d3 into main Nov 16, 2026
7 of 8 checks passed
@Kzoeps
Kzoeps deleted the search/org-legalname branch November 16, 2026 10:33
@hypercerts-release-bot hypercerts-release-bot Bot mentioned this pull request Nov 16, 2026

This branch was successfully deployed

1 active deployment
Preview — 619c9eee Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant