Repository navigation
Conversation
- Adds the `OmitLebelsFlag` field to the `ListCmd` struct to allow omitting the labels flag for commands that do not support it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
=======================================
Coverage 79.60% 79.61%
=======================================
Files 305 305
Lines 9794 9795 +1
=======================================
+ Hits 7797 7798 +1
Misses 1997 1997
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Could we already configure the hetzner managed API resource to not use the label selector?
|
jooola
reviewed
Nov 17, 2026
Comment on lines
+65
to
68
| // Can be set to indicate that the [ListCmd] for a resource does not support labels. | ||
| // As result the corresponding flag will not be printed in the help text or documentation. | ||
| OmitLabelsFlag bool | ||
| } |
Member
There was a problem hiding this comment.
For the --sort, we explicitly set the sort option, or nil of not supported.
This feels like we take the other approach, labels are present by default, implicit.
Maybe we could turn this around, and explicitly enable labels LabelsFlag ?
What do you think?
jooola
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OmitLabelsFlagfield to theListCmdstruct to allow omitting the labels flag for commands that do not support it.