Repository navigation
fix: remove commands --sort flag when not unsupported - #1546
Closed
goransh-walia wants to merge 2 commits into
Closed
goransh-walia wants to merge 2 commits into
goransh-walia wants to merge 2 commits into
Conversation
--sort shown where sorting is unsupported--sort flag when not unsupported
Member
|
We appreciate the intend, but the changes in this PR are not good enough. Next time, please run the tests locally, run the linter, and make sure the generated files are up to date. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1536
Summary
This PR prevents the
--sortflag from appearing in the help text and documentation for list commands that do not support sorting.Root cause
The
ListCmdimplementation unconditionally added thesortflag to the cobra command, regardless of whether theSortOptionfield was initialized.Changes
internal/cmd/base/list.goto wrap the--sortflag definition in anilcheck forlc.SortOption.Testing
internal/cmd/base/list_test.go(not executed locally).AI-assisted.