Skip to content

Add punchbowl and solpolpy - #398

Open
jmbhughes wants to merge 2 commits into
heliophysicsPy:mainfrom
punch-mission:main
Open

jmbhughes wants to merge 2 commits into
heliophysicsPy:mainfrom
punch-mission:main

Conversation

@jmbhughes

Copy link
Copy Markdown
Contributor

Hi! We talked about this at DASH 2026. I hope it's not too unusual to add two packages at the same time.

Let me know if you have any questions or comments on our grading.

@sapols

sapols commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Thanks Marcus! I'm happy to see these submissions and I fully expect to accept them. But I might not get around to reviewing them for another couple weeks because my schedule is pretty full. Just wanted to let you know I've seen this :)

@sapols

sapols commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for your patience, @jmbhughes! I finally reviewed both packages and they’ll obviously be great additions to PyHC. I just have a couple requests before we wrap this up:

  1. Please change both logo links to direct image URLs. The current links return HTML pages, so they won’t render on the project cards. This raw image link works if you’d like to use the same logo for both.

  2. punchbowl’s dependency bounds: The PHEP 3 and Environment compatibility checks flag:

    • The SunPy and NDCube upper bounds exclude the Environment’s current versions: SunPy 8.0.1 and NDCube 2.4.3.
    • scipy>=1.16.1 excludes SciPy 1.15 while it is still within the PHEP 3 support window.

Full Environment compatibility isn’t an absolute requirement for joining PyHC, but I’d really prefer to resolve this before merging so we can include both packages in the Environment. Would you be open to relaxing punchbowl’s bounds to address these issues, and publishing an updated release? The PyHC actions checks can help verify the changes. solpolpy already passes both checks, so that one's fine.

Thanks again for submitting both!

@sapols

sapols commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

And my apologies but heads up again, I'm actually going on vacation next week so it might be another couple weeks before I return here. I'm swear I'm usually faster with these lol, chalk it up to holiday craziness.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants