Repository navigation
Conversation
|
Thanks Marcus! I'm happy to see these submissions and I fully expect to accept them. But I might not get around to reviewing them for another couple weeks because my schedule is pretty full. Just wanted to let you know I've seen this :) |
|
Thanks for your patience, @jmbhughes! I finally reviewed both packages and they’ll obviously be great additions to PyHC. I just have a couple requests before we wrap this up:
Full Environment compatibility isn’t an absolute requirement for joining PyHC, but I’d really prefer to resolve this before merging so we can include both packages in the Environment. Would you be open to relaxing punchbowl’s bounds to address these issues, and publishing an updated release? The PyHC actions checks can help verify the changes. solpolpy already passes both checks, so that one's fine. Thanks again for submitting both! |
|
And my apologies but heads up again, I'm actually going on vacation next week so it might be another couple weeks before I return here. I'm swear I'm usually faster with these lol, chalk it up to holiday craziness. |
Hi! We talked about this at DASH 2026. I hope it's not too unusual to add two packages at the same time.
Let me know if you have any questions or comments on our grading.