Repository navigation
e2e: TestListenDefaultIPv6 takes a port free on every address - #385
Merged
Merged
Conversation
ListenTo DEFAULT binds the wildcard (IPv4 and IPv6), but the port came from freeAddr, which checks only 127.0.0.1, and standalone() retried a bind collision only for the automatic loopback listener. On a busy CI runner (Fedora 43, 2026-11-14) another test's listener held the port and the daemon exited with "can't listen on ListenTo DEFAULT:41577: Address already in use". freeDefaultPort checks the wildcard; standalone() also retries a collision of ListenTo DEFAULT:<port> with a new port. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI flake: Fedora 43 on PR #381 (2026-11-14) failed
TestListenDefaultIPv6withcan't listen on ListenTo DEFAULT:41577: Address already in use.Cause:
ListenTo DEFAULTbinds the wildcard (IPv4 and IPv6), but the test took its port fromfreeAddr, which only checks 127.0.0.1, andstandalone()retried a bind collision only for the automatic loopback listener, not forListenTo DEFAULT:<port>.freeDefaultPort(harness): a port free on the wildcard (net.Listen("tcp", ":0")).standalone(): a "can't listen on ListenTo DEFAULT:" collision is retried with a new port (bothListenToande.Listenmove), like the loopback case.e.Listenafterstandalone().Test-only change, no NEWS entry. Not run on the maintainer's workstation; CI here.
🤖 Generated with Claude Code