Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| git rev-parse --verify origin/main | ||
| ``` | ||
|
|
||
| Detect which ecosystems have pending updates: |
There was a problem hiding this comment.
🧹 Separate discovery from update checks: Finding dependency files does not establish that updates are available; the later dependency checks still perform that work.
| ```bash | ||
| [ -f Cargo.toml ] && echo "cargo" | ||
| ls .github/workflows/*.yml .github/workflows/*.yaml 2>/dev/null && echo "github-actions" | ||
| { ls .github/workflows/*.yml || ls .github/workflows/*.yaml; } 2>/dev/null && echo "github-actions" |
There was a problem hiding this comment.
🛠️ Include workflow dependencies: The repository includes GitHub Actions in dependency updates, but the combined ls command suppresses its marker when either filename pattern has no matches. Checking the patterns separately works with either extension; this remains file discovery, not an update check.
|
|
||
| ## Guidelines | ||
|
|
||
| - **All PRs target `main`.** There is no separate dev branch. |
There was a problem hiding this comment.
🧹 Keep one target-branch rule: Removing this duplicate leaves the existing requirement to target main in place. The separate prohibition on pushing directly to main also remains.
|
|
||
| ## Edge cases | ||
|
|
||
| - **Cargo workspace:** Dependencies are declared per-crate but share a single `Cargo.lock` at the workspace root. Always run `cargo update` and `cargo check` from the repo root. |
There was a problem hiding this comment.
🧹 Keep Cargo instructions with their commands: The Cargo update recipe already requires the repository root and retains the shared-lockfile explanation. Removing this duplicate changes no working-directory requirement.
| - **npm:** Look for `package.json` files to discover npm packages rather than hardcoding paths — the repo layout may change. | ||
| - **WASM builds:** After updating `wasm-bindgen` or related deps, verify `make build-js` still works — WASM toolchain version mismatches are common. | ||
| - **Rate limits:** If `gh api` hits rate limits, wait and retry. Report to user if persistent. | ||
| - **Nothing to update:** Report cleanly and move to the next ecosystem (or exit). |
There was a problem hiding this comment.
🧹 Keep one no-updates branch: The existing ecosystem rules already require skipping unchanged ecosystems, telling the user, and completing one ecosystem before moving to the next. That behavior remains covered.
There was a problem hiding this comment.
🟢 Approval recommended
The reviewed skill update addresses workflow-extension detection and removes redundant guidance with no documented unresolved issues.
No open issues 🎉
What changed in this PR
Updates the update-deps skill to reliably detect GitHub Actions workflow files using either .yml or .yaml, while simplifying redundant dependency-update guidance.
Changes:
- Added fallback detection for both workflow file extensions.
- Removed duplicated workflow, branch-target, Cargo workspace, and no-update guidance.
- Kept dependency discovery separate from checking update availability.
| File | Description |
|---|---|
.github/skills/update-deps/SKILL.md |
Refines dependency ecosystem discovery and simplifies duplicated workflow and edge-case guidance. |
Review effort: Lite (auto)
🧠 How this helps Copilot
Copilot could miss workflow dependencies or mistake finding dependency files for proof that updates are available. The guidance now recognizes the repository's workflow files and keeps dependency discovery separate from checking for available updates.
Automated details
Source:
curate-memoriesDream, analyzingmainat31331e8.make testcould not complete: benchmark equivalence tests require tokenizer files fromhuggingface.co, whose hostname could not be resolved.