Repository navigation
Route Constraint Solving — Problem of the Day with economy model routing instead of pinning claude-haiku-4.5 - #74595
Conversation
…inning claude-haiku-4.5 Co-authored-by: SivaKesava1 <11771739+SivaKesava1@users.noreply.github.com>
claude-haiku-4.5
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the switch to cost-focused economy routing.
No open issues 🎉
What changed in this PR
Updates the daily constraint-solving workflow to use cost-focused economy model routing instead of a fixed claude-haiku-4.5 model, implementing the configuration change requested in #74588.
Changes:
- Enables economy routing while preserving Copilot CLI,
bare: true, authentication, prompts, and workflow controls. - Regenerates the lock file with router setup, routed-model reporting, and routing artifacts; threat detection returns to default model selection.
- Leaves cost auditing and output-quality checks for follow-up; projected savings remain unverified by routed runs.
| File | Description |
|---|---|
.github/workflows/constraint-solving-potd.md |
Replaces the fixed model with cost-focused economy routing. |
.github/workflows/constraint-solving-potd.lock.yml |
Adds compiled routing support, updates model reporting, and removes the inherited detection pin. |
Review effort: Balanced (auto)
There was a problem hiding this comment.
Reviewed the changed workflow configuration and generated-lock implications. I found no actionable correctness, security, or maintainability issues on the changed lines. The economy routing configuration matches existing repository patterns; generated lock-file changes are represented in PR metadata though excluded from the capped review patch.
🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · ~1 AIC · ⌖ ~1 AIC · ⊞ 1.6K
Comment /review to run again
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /grill-with-docs to the workflow change. The routing config is valid and the committed lock matches the description. One behaviour change needs confirming before merge.
📋 Key Themes & Highlights
Key Themes
- Threat detection is unpinned: removing
model: claude-haiku-4.5also removes the model that detection inherited. Detection now falls back to thedetectionalias (small→mini), which can resolve to a different model. Detection is a security gate, so this should be pinned or called out explicitly. - PR description mismatch: it says detection falls back to
auto, but the committed lock uses'detection'.
Positive Highlights
- ✅ The
model-routingblock matches the schema (goal: cost,mode: economy) and other routed workflows in the repo. - ✅ The lock adds the routing step, AWF
modelRoutingconfig, and the pinned router image, consistent with the source.
Scope
Reviewed committed head 65365ec. The lock file is generated, so I checked only its routing-related lines.
@copilot please address the inline comment on threat-detection model handling.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · routed: haiku55 xhigh · ~6 AIC · ⌖ ~1 AIC · ⊞ 5.5K
Comment /matt to run again
Constraint Solving — Problem of the Day is pinned to
claude-haiku-4.5, and threat detection inherits the pin. Switching to economy routing is estimated to cut usage from about 128 to 30–46 AIC/week and moves the workflow off the older model.Workflow change (
.github/workflows/constraint-solving-potd.md)Everything else is unchanged: prompt, triggers, cache-memory, evals, safe outputs and
COPILOT_GITHUB_TOKENauthentication. There is no model allow/block list. Only this workflow was compiled; it is the only workflow diff againstmain.Lock-file changes (
constraint-solving-potd.lock.yml)experimental.modelRouting: true, the model config hasrouting: {enabled: true, goal: cost, mode: economy}, and the run step setsGH_AW_MODEL_ROUTING: 1.ghcr.io/github/gh-aw-firewall/router:0.29.6@sha256:fce2f3be…is pinned and downloaded.COPILOT_MODEL: claude-haiku-4.5and the haiku cost table are gone from the agent job.vars.GH_AW_MODEL_DETECTION_COPILOT || vars.GH_AW_DEFAULT_MODEL_COPILOT || 'detection', with anautofallback).model,model_effortandmodel_routing_statusfrom the agent job instead of the hard-coded model name.awf-routing-outcome.jsonandaw_info.jsonare added to the uploaded artifacts.Not in this PR
gh aw audit <run>against about 18 AIC/run.model: claude-haiku-4.5line.make agent-finishfailures are on files this PR doesn't change: golint findings inpkg/cli,TestDownloadWorkflowLogsForTargets*, the JS testssend_otlp_span,awf_reflect_summaryandcopilot_sdk_mcp_config, and USE-001 inmcp_http_server_runner.cjs.validate-otel-contract,fixandsecurity-govulncheckalso fail and weren't investigated. None of these were re-run onmainfor comparison, and most are not on the known-failures list formain.