Skip to content

Exclude Notify from required checks - #4311

Open
henrymercer wants to merge 1 commit into
mainfrom
henrymercer/exclude-notify-from-required-checks
Open

henrymercer wants to merge 1 commit into
mainfrom
henrymercer/exclude-notify-from-required-checks

Conversation

@henrymercer

Copy link
Copy Markdown
Contributor

Exclude Notify from the checks that pr-checks/sync-checks.ts makes required. This check comes from the PR dequeued workflow and only runs when a PR is removed from the merge queue, so requiring it would block PRs from merging.

Risk assessment

For internal use only. Please select the risk level of this change:

  • Low risk: Changes are fully under feature flags, or have been fully tested and validated in pre-production environments and are highly observable, or are documentation or test only.

Which use cases does this change impact?

Environments:

  • Testing/None - This change does not impact any CodeQL workflows in production.

How did/will you validate this change?

  • Other - Before this change, a dry run of pr-checks/sync-checks.ts --ref e70c0414bf2f50ae4617cac7ffe7db16cd2bf06b, the head of a PR that had been removed from the merge queue, proposed adding Notify to main, releases/v3 and releases/v4. With this change, the dry run excludes it and proposes no changes.

If something goes wrong after this change is released, what are the mitigation and rollback strategies?

  • Development/testing only - This change cannot cause any failures in production.

How will you know if something goes wrong after this change is released?

  • Other

Are there any special considerations for merging or releasing this change?

  • No special considerations - This change can be merged at any time.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Consider adding a changelog entry for this change.
  • Confirm the readme and docs have been updated if necessary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI auto review requested due to automatic review settings November 9, 2026 11:05
@github-actions github-actions Bot added the size/XS Should be very easy to review label Nov 9, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are identified, and the change addresses the merge-queue-only Notify check by excluding it from required checks and documenting when it runs.

No open issues 🎉

What changed in this PR

This pull request excludes the merge-queue-only Notify check from required status checks so it cannot block pull requests that did not trigger it.

Changes:

  • Adds Notify to the exact-match exclusions.
  • Documents that the check runs only when a pull request is removed from the merge queue.

This pull request is ready to be approved.

File Description
pr-checks/​excluded.yml Excludes the merge-queue-only Notify check from required checks.

Review effort: Lite (auto)

@henrymercer
henrymercer marked this pull request as ready for review November 9, 2026 11:37
@henrymercer
henrymercer requested a review from a team as a code owner November 9, 2026 11:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Should be very easy to review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants