Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #69, targeting its branch.
#69 calls the handler's own
setPrototypeOftrap after the cycle check. This makes that call behave like a nativeProxyin two more cases:nulltrap is ignored. Before,{ setPrototypeOf: null }threw aTypeError.The cycle check still runs first. The trap must still be the handler's own property, so page code cannot add one through
Object.prototype.Not covered
thisis an internal object that inherits from the handler, not the handler itself. Traps can share state throughthis, butthis === handleris false and writes tothisdo not show up on the handler. This has been the case since Reject cyclic prototypes on scriptlet proxies #67.