Repository navigation
Reject prototype cycles across scriptlet proxies - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #67, targeting its branch.
What changes
WeakSetand the capturedadd/has/Reflect.applygo away. Thehandler instanceof Object,handler.setPrototypeOf === undefinedandnew.targetguards are dropped too: every caller is a scriptlet passing an object literal with nosetPrototypeOftrap, always withnew. Droppinginstanceofalso removes aSymbol.hasInstancelookup that ran after page scripts.Testing
setTimeoutandFunction.prototype.toString, both proxied byprevent-setTimeout.js, each set as the other's indirect prototype, compared against two native functions. It fails on Reject cyclic prototypes on scriptlet proxies #67 withRangeError: Maximum call stack size exceededand passes here.npm run buildandnpm testpass locally (10 tests).Not covered
Object.setPrototypeOf(Function.prototype, Function.prototype.toString). The proxy's trap never runs, so this needs page-wide patching of the prototype setters and is left out.setPrototypeOftrap to a handler, the wrapper shadows it.