Repository navigation
fix(core): Restore touch breadcrumbs on New Architecture from RN 0.88 - #7013
Merged
Merged
Conversation
With EventTarget-based dispatching, touch events have no `_targetInst`, so TouchEventBoundary silently recorded nothing. Fall back to the fiber on the event target. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2f7fe4e. Configure here.
The existing tests hand-build events, so they cannot detect React Native changing how the touched fiber is exposed. Run the boundary through the real renderer and event dispatch, and warn in debug when no fiber is found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
antonis
marked this pull request as ready for review
November 10, 2026 12:51
antonis
requested review from
alwx and
buenaflor
and removed request for
a team
November 10, 2026 12:51
📲 Install BuildsAndroid
|
antonis
enabled auto-merge (squash)
November 11, 2026 12:32
Contributor
3 tasks done
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
TouchEventBoundarynow falls back toe.target.__internalInstanceHandlewhen the touch event has no_targetInst._targetInststays the first choice, so older React Native versions and the Old Architecture keep their existing path.This restores touch breadcrumbs, rage tap detection and user interaction spans, which all returned early on the missing
_targetInst. Label reading, text extraction andSentry.Maskhandling run on the same fiber as before.💡 Motivation and Context
Fixes #7009
💚 How did you test it?
Touch event within element: TextTouch event within element: Text📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps