Repository navigation
Conversation
Functions wrapped with sentry_sdk.monitor get a marker, and arq skips cron jobs that already report their own check-ins. The arq time zone lookup moves to a shared helper that only sends names that look like IANA zones.
The worker can run the job again when a cron slot falls due during the test.
Contributor
Coverage Results 📊✅ 137221 passed | ⏭️ 7456 skipped | Total: 144677 | Pass Rate: 94.85% | Execution Time: 454m 59s 📊 Comparison with Base Branch
All tests are passing successfully. ✅ Patch coverage is 95.83% (23 of 24 changed executable lines covered; target 80%). Changed files with executable lines (3)
Coverage diff@@ Coverage Diff @@
## master #8198 +/-##
==========================================
- Coverage 90.33% 90.30% -0.03%
==========================================
Files 203 203 —
Tracked lines 26922 26933 +11
Branches 10056 10058 +2
==========================================
+ Hits 24319 24320 +1
- Misses 2603 2613 +10
- Partials 1516 1519 +3Generated by Coverage Action |
GitHub didn't sync the previous push to the PR.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Marks functions wrapped with
@sentry_sdk.monitor, so scheduler integrations can skip jobs that already send their own check-ins. The arq integration now does this, so those jobs don't report twice.Also moves arq's time zone lookup into
sentry_sdk/crons/utils.pyso other cron integrations can share it, and stops sending names that aren't IANA zones (like tzlocal'slocal), which Sentry would reject.This is the base for #7840 (APScheduler), which uses both.
Testing
New arq test for a
@sentry_sdk.monitorcron job. The existing arq time zone tests cover the helper.