Repository navigation
fix(core): Fix 9.x.x compile error in SentryTracer.hasAllChildrenFinished - #6595
Merged
Merged
Conversation
sentry-junior
Bot
requested review from
0xadam-brown and
romtsn
and removed request for
a team
November 12, 2026 11:27
📲 Install BuildsAndroid
|
adinauer
approved these changes
Nov 12, 2026
markushi
approved these changes
Nov 12, 2026
2 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Replaces
span.getOptions().isIdle()withspan.isIdle()inSentryTracer.hasAllChildrenFinished(). That one line is the whole change.💡 Motivation and Context
9.x.x(fb3e477) currently doesn't compile:#6417 removed
Span.getOptions()in favor ofSpan.isIdle()and updated this call. #6415 was merged 4 minutes later and brought the old call back. Every PR against9.x.xnow fails CI at:sentry:compileJava, for example #6594.💚 How did you test it?
./gradlew :sentry:compileJava :sentry:compileTestKotlin :sentry:spotlessJavaCheckpasses locally.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
Once this is merged, re-run CI on the open PRs against
9.x.x.#skip-changelog
via alexander.dinauer.
--
View Session [Sentry]