Repository navigation
Conversation
📲 Install BuildsAndroid
|
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
markushi
commented
Nov 12, 2026
| */ | ||
| final class ApplicationNotResponding extends RuntimeException { | ||
| @ApiStatus.Internal | ||
| public final class ApplicationNotResponding extends RuntimeException { |
Member
Author
There was a problem hiding this comment.
had to change the visibility, otherwise the helper could not have accessed it. Moving this class probably isn't an option, as it's used for captureException() and thus could influence issue grouping.
markushi
marked this pull request as ready for review
November 12, 2026 10:55
markushi
requested review from
0xadam-brown and
romtsn
and removed request for
a team
November 12, 2026 10:55
0xadam-brown
approved these changes
Nov 12, 2026
0xadam-brown
left a comment
0xadam-brown
left a comment
Member
There was a problem hiding this comment.
One quick question in case it's helpful; otherwise lgtm 👍
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| @ApiStatus.Internal | ||
| public final class AnrCulpritEventHelper { |
Member
There was a problem hiding this comment.
I imagine I'll learn more as more PRs emerge, but (for now) it looks like there's a lot of overlap between this class an the existing AnrCulpritIdentifier. Just making sure we don't want to extend the latter instead?
(Happy to defer to you.)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Moves the code that turns an ANR profile culprit into event exceptions out of
ApplicationExitInfoEventProcessorinto a newAnrCulpritEventHelper:toSentryExceptions(culprit, mechanism)builds theApplicationNotRespondingexception from the culprit stack.hasOnlySystemFrames(exceptions)decides whether an ANR gets the static system-frames fingerprint.The fatal ANR event does not change.
💡 Motivation and Context
Prep work for non-fatal ANRs. The non-fatal ANR event needs the same culprit exception and fingerprint rule as the fatal one, so both event producers will share this helper.
💚 How did you test it?
Added
AnrCulpritEventHelperTest. The existingApplicationExitInfoEventProcessorTestandAnrV2IntegrationTestpass without changes.📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
The non-fatal ANR integration will use this helper.
#skip-changelog
🤖 Generated with Claude Code