Repository navigation
Conversation
…radle Plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 of 4 tasks
Contributor
|
📲 Install BuildsAndroid
|
…rror Also keeps the automatic refresh out of the manual adoption count, warns about a missing androidx.webkit only once, and documents that the refresh keeps explicitly passed hosts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 633c585. Configure here.
1 of 6 tasks
antonis
marked this pull request as ready for review
November 12, 2026 10:52
antonis
requested review from
markushi and
runningcode
and removed request for
a team
November 12, 2026 10:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Adds
SentryWebViewTracingAdapter, an internal class that the Sentry Android Gradle Plugin calls in place ofWebView.loadUrl(getsentry/sentry-android-gradle-plugin#1505). It refreshes the trace propagated to the page, then calls the originalloadUrl:http(s)URLs trigger a refresh, sojavascript:URLs are left alone.addTracePropagationfor that WebView, or elsewebViewTracing.allowedHostsfrom the options, so a WebView the app limited to specific hosts isn't widened to the app-wide list.LinkageErrorfrom a missing or outdatedandroidx.webkit. The load always happens.WebViewTracePropagation), since the plugin reports its ownWebViewInstrumentationfeature, and it warns about a missingandroidx.webkitonly once.The plugin calls this adapter rather than
SentryWebViewTracing.addTracePropagation(webView)directly, because that method removes the existing script when no hosts are set and can throw into the app's code. The adapter keeps a script the app installed, and never changes how the load behaves.💡 Motivation and Context
Part of #6407
💚 How did you test it?
Unit tests for the adapter and the refresh.
End to end, with a local build of the plugin and the sample app on an emulator (Pixel 8, API 37). The sample's WebView, a subclass, had no manual
addTracePropagationcall. The plugin rewrote itsloadUrlcall, and the page joined the app's trace:With the plugin's WebView feature turned off, the page received no trace.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps