Repository navigation
return 400 for filters the SQL provider cannot apply - #2483
Open
colivetree wants to merge 1 commit into
Open
colivetree wants to merge 1 commit into
colivetree wants to merge 1 commit into
Conversation
A filter value the column type cannot hold, or a CQL filter that compares a quoted column name, raised an uncaught exception and returned an HTML 500. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UA1Vh8atCEhdk3WycqYunj
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A filter the SQL provider can't apply now returns a 400 instead of an uncaught exception and an HTML 500:
osm_id=x), on PostgreSQLosm_id LIKE 'a%'), on PostgreSQL'name' LIKE 'a%'), on PostgreSQL and MySQLMost of the
sql.pydiff is re-indentation from the newtry.git diff -wshows the 30 or so lines that really changed.Related Issue / discussion
Closes #2480
Additional information
Faults the request didn't cause stay errors: a
DataErrorwith no filter, a misconfiguredtime_field, and anyProgrammingErrorother than42883.Testing:
main (3.12)), plusflake8.osm_id=xand the CQL cases went from an HTML 500 to a JSON 400.An AI assistant (Claude Code) helped me investigate this and prepare the patch. I'm directing the work and will follow it through.
Dependency policy (RFC2)
No new dependencies.
Updates to public demo
No configuration changes.
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)
🤖 Generated with Claude Code
https://claude.ai/code/session_01UA1Vh8atCEhdk3WycqYunj