Repository navigation
404 and Glossary references: area doors on 404 and scannable bibliography with Cited in column - #1266
Open
LukasWallrich wants to merge 7 commits into
Open
LukasWallrich wants to merge 7 commits into
LukasWallrich wants to merge 7 commits into
Conversation
…jacent Cited in column Give /404.html a FORRT recovery layout leading with site search and a quieter home button, followed by FORRT's four Strategic Focus Areas in their Doors colours and illustrations, with broken-link reporting moved below. Keep all client-side legacy redirects intact. On /glossary/references/, place each entry's Cited in glossary links in a dedicated pale Education column on wide screens (and a clean tinted band on phones), add an All / Linked to terms filter with counts, style Show more authors as a plain underlined link, keep the first reference visible on phones, and add content-visibility rendering for the 712-item list. Co-Authored-By: Gemini 4 Neon <noreply@google.com>
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
Contributor
✅ Spell Check PassedNo spelling issues found when checking 28 changed file(s)! 🎉 |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
article.css sets 18px!important across glossary reference lists, matching DESIGN.md's 18px body scale; drop the dead 16px declarations in glossary.css. Co-Authored-By: Gemini 4 Neon <noreply@google.com>
Satisfies WCAG 2.2 Level AA target-size (24x24 px) in Accessibility rules without altering the inline underlined link styling. Co-Authored-By: Gemini 4 Neon <noreply@google.com>
…et-size Prevents the 24px Show-more-authors button from overlapping adjacent DOI links under axe-core's WCAG 2.2 Level AA target-size check (0 violations at 390 and 1440 px). Co-Authored-By: Gemini 4 Neon <noreply@google.com>
Off-screen letter groups with content-visibility:auto report skipped or collapsed layout boxes to axe-core's WCAG 2.2 AA target-size audit, causing false failures on .ref-authors-toggle buttons at 1440 px. Removing it yields 0 violations and 0 incomplete checks across all 82 buttons at 390 and 1440 px. Co-Authored-By: Gemini 4 Neon <noreply@google.com>
… title
Replace the four stacked area cards on phones (<= 760 px) with four single-tap
area-tinted links so the entire 404 page fits on one phone screen, while
keeping the full four-column area cards on desktop. Also switch the title in
content/glossary/_build_references.py from 'List of References' to sentence
case ('Glossary references').
Co-Authored-By: Gemini 4 Neon <noreply@google.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Gemini 4 Neon <noreply@google.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visitors who hit a broken link or browse the 712-entry glossary bibliography now have clearer paths back into FORRT's collections.
/404.html): leads immediately with site search and an outlined Back to the home page button at both widths. On desktop, four Doors area cards (Education & Pedagogy, Meta-Science & Research, Social Justice & DEIA, Community & Sustainability) show each area's brick illustration, colour and key destinations; on phones (<= 760 px), they collapse into four compact, area-tinted single-tap links so the whole 404 page fits cleanly on one screen. Broken-link reporting remains quietly below, and all client-side legacy redirect rules are untouched./glossary/references/): on wide screens, each entry's Cited in glossary links move into a dedicated pale Education column beside the APA citation so two-word term names stay on one line and the right half of the page is no longer empty. An All (712) / Linked to terms (543) toggle lets readers narrow to linked sources, Show more authors is now an underlined text link with a 24 px target height rather than a pill inside the citation, and the first full reference stays visible on the first phone screen. Updatedcontent/glossary/_build_references.pyto write sentence-caseGlossary referenceson the next data-processing run (leaving generatedcontent/glossary/references/index.mduntouched on this branch).Before and after
/404.html— 1440 px Before/404.html— 1440 px After/404.html— 390 px Before/404.html— 390 px After/glossary/references/— 1440 px Before/glossary/references/— 1440 px After/glossary/references/— 390 px Before/glossary/references/— 390 px AfterDecisions to review
/dei/) there too if you prefer matching counts.title: Glossary referencesincontent/glossary/_build_references.py(will apply on the nextdata-processingrun onmain; happy to switch toList of referencesif you prefer keeping the old wording).Checks
hugobuild succeeded cleanly (0errors)python3 scripts/rebrand/check_source_rules.py --base origin/main—0hard-coded URLs,0generated files touchedpython3 scripts/check_seo_html.py— all 24 checks PASS🤖 Generated with Gemini 4 Neon