Skip to content

Fix syntax errors in code-documentation Dart reference snippets - #262

Closed
reidbaker-agent wants to merge 1 commit into
flutter:mainfrom
reidbaker-agent:mark/fix-flutter-skills-snippets
Closed

reidbaker-agent wants to merge 1 commit into
flutter:mainfrom
reidbaker-agent:mark/fix-flutter-skills-snippets

Conversation

@reidbaker-agent

Copy link
Copy Markdown
Member

Fixes two Dart syntax errors in .agents/agents/reidbaker-agent/skills/code-documentation/references/dart.md caught by static analysis of Markdown code blocks:

  1. Replace { ... } inside the PurchaseButton class declaration body with a valid comment placeholder (// ...).
  2. Add the missing closing brace } to the FlightPath class declaration.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Dart code snippets in the dart.md documentation file to improve formatting and syntax. The feedback correctly identifies that the FlightPath class snippet is missing the declaration of the coordinates field, which would cause a compile-time error, and provides a code suggestion to resolve it.

///
/// The [coordinates] must contain at least two points.
const FlightPath({required this.coordinates, super.key});
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The constructor of FlightPath uses this.coordinates as an initializing formal parameter, but the coordinates field is not declared in the class. In Dart, this results in a compile-time error because the class doesn't have an instance field named coordinates.

To make the snippet fully valid, declare the coordinates field within the class.

Suggested change
}
final List<Point> coordinates;
}

@reidbaker-agent
reidbaker-agent force-pushed the mark/fix-flutter-skills-snippets branch from 8c29f00 to e747ee7 Compare November 4, 2026 00:46
@reidbaker

Copy link
Copy Markdown
Member

low quality change, closing

@reidbaker reidbaker closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants