Repository navigation
feat(flow-php/postgresql): libpq quoting, session settings and bundle connection options - #2739
Merged
Merged
Conversation
… connection options - ConnectionParameters::toString() quotes values, fromString() follows libpq conninfo_parse - ConnectionParameters::OPTION_KEYS as the one libpq key list, with PostgreSQL 16-18 keys - withSessionSettings() writes "-c name=value" pairs into the options key - symfony-postgresql-bundle: per-connection options and session_settings
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2739 +/- ##
============================================
+ Coverage 91.04% 91.06% +0.01%
- Complexity 32120 32159 +39
============================================
Files 2237 2237
Lines 92882 92941 +59
============================================
+ Hits 84566 84633 +67
+ Misses 8316 8308 -8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #xxx
Change Log
Added
flow-php/postgresql-ConnectionParameters::withSessionSettings()for server settings likestatement_timeoutflow-php/postgresql-ConnectionParameters::OPTION_KEYSwith the libpq keys of PostgreSQL 16 to 18flow-php/symfony-postgresql-bundle-optionsandsession_settingsfor each connectionFixed
flow-php/postgresql-ConnectionParameters::toString()quotes values with whitespace, quotes or backslashesflow-php/postgresql-ConnectionParameters::fromString()reads escaped and quoted values by the libpq rulesflow-php/postgresql-pgsql_connection()docblock no longer claims URL supportChanged
flow-php/postgresql-ConnectionParameters::fromString()throws on a keyword without=and on an unterminated quoteflow-php/postgresql- anoptionsvalue that escapes spaces with a backslash no longer worksRemoved
Deprecated
Security