Skip to content

Remove support for Azure attestation - #115

Open
ameba23 wants to merge 5 commits into
mainfrom
peg/rm-azure
Open

ameba23 wants to merge 5 commits into
mainfrom
peg/rm-azure

Conversation

@ameba23

@ameba23 ameba23 commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

This removes support for vTPM attestation on Microsoft Azure as we no longer use it.

@ameba23
ameba23 marked this pull request as draft November 17, 2026 13:58
Base automatically changed from peg/attestation-provider-uses-unix-socket to main November 20, 2026 12:12
@ameba23
ameba23 requested a balanced review from Copilot November 20, 2026 13:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The fixture refresh script can hide curl failures and report success after truncating the fixture because the pipeline exit status reflects only jq.

1 open issue
What changed in this PR

Removes unused Azure vTPM attestation support from the attestation crate while retaining DCAP and GCP support.

Changes:

  • Removes Azure generation, verification, trust roots, dependencies, and build configuration.
  • Rejects unsupported evidence explicitly and adds regression tests.
  • Updates documentation, measurement fixtures, and CI for the remaining supported platforms.
File Description
shell.nix Removes the Azure dependency shell.
readme.md Removes Azure environment setup instructions.
crates/​attestation/​test-assets/​refresh-buildernet-measurements-fixture.sh Filters refreshed fixtures to DCAP and GCP records.
crates/​attestation/​test-assets/​measurements.json Removes Azure measurement examples.
crates/​attestation/​test-assets/​buildernet_measurements.json Removes Azure records and formats retained measurements.
crates/​attestation/​test-assets/​azure-collateral02.yaml Deletes Azure collateral fixture.
crates/​attestation/​test-assets/​azure-collateral.yaml Deletes Azure collateral fixture.
crates/​attestation/​test-assets/​azure-collateral-with-ak-intermediates-1780922561.yaml Deletes collateral for the Azure intermediate-certificate fixture.
crates/​attestation/​src/​lib.rs Removes Azure APIs and tests explicit unsupported-evidence rejection.
crates/​attestation/​src/​gcp/​firmware.rs Updates the test verification call signature.
crates/​attestation/​src/​dcap.rs Removes the Azure TCB override and simplifies verification calls.
crates/​attestation/​src/​azure/​verify.rs Deletes Azure evidence verification.
crates/​attestation/​src/​azure/​tpms_attest.rs Deletes TPM attestation parsing.
crates/​attestation/​src/​azure/​tpm_quote.rs Deletes vTPM quote verification.
crates/​attestation/​src/​azure/​mod.rs Deletes Azure evidence types and errors.
crates/​attestation/​src/​azure/​attester/​nv_index.rs Deletes TPM storage access helpers.
crates/​attestation/​src/​azure/​attester/​mod.rs Deletes Azure detection and evidence generation.
crates/​attestation/​src/​azure/​ak_certificate.rs Deletes Azure attestation-key certificate verification.
crates/​attestation/​README.md Documents the remaining supported platforms and policies.
crates/​attestation/​Cargo.toml Removes Azure features and dependencies.
crates/​attestation/​build.rs Removes Azure-specific target configuration.
crates/​attestation/​assets/​microsoft-rsa-devices-root-ca-2021.pem Deletes the Microsoft devices trust root.
crates/​attestation/​assets/​azure-virtual-tpm-root-2023.pem Deletes the Azure vTPM trust root.
Cargo.lock Prunes Azure-related dependencies.
.github/​workflows/​test.yml Replaces Azure-specific checks with production, default-feature, and all-feature checks.

Review effort: Balanced

@ameba23
ameba23 marked this pull request as ready for review November 20, 2026 14:42
@ameba23
ameba23 requested a balanced review from Copilot November 20, 2026 14:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A grammar nit remains at crates/attestation/src/lib.rs:640, where the singular subject “DCAP verification” needs the verb “requires.”

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread crates/attestation/src/lib.rs Resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants