Skip to content

Support separate quote provider over unix socket - #195

Open
ameba23 wants to merge 2 commits into
mainfrom
peg/attestation-provider-server-improvements
Open

ameba23 wants to merge 2 commits into
mainfrom
peg/attestation-provider-server-improvements

Conversation

@ameba23

@ameba23 ameba23 commented Nov 20, 2026

Copy link
Copy Markdown
Collaborator

This PR updates the attestation crate to use the merged Unix-socket provider API.

It replaces the --dev-dummy-dcap command line option with --attestation-provider-socket or ATTESTATION_PROVIDER_SOCKET.

If a provider is used, an explicit local attestation type must be given - as platform detection is not possible due to permissions.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The newly pinned attestation dependency is unavailable in this checkout, so provider interoperability, socket validation, and failure handling require human verification.

No open issues 🎉

What changed in this PR

This PR migrates attestation generation to the upstream Unix-socket provider API, allowing the proxy to delegate quote generation and platform metadata collection to a separate local service.

Changes:

  • Replaces --dev-dummy-dcap with --attestation-provider-socket and ATTESTATION_PROVIDER_SOCKET across all five supported commands.
  • Requires an explicit local attestation type when using a provider, while preserving explicit none support.
  • Updates dependencies, adds provider and CLI tests, and documents configuration and migration.
File Description
README.md Documents provider configuration, permissions, and migration.
crates/​attested-tls/​tests/​attestation_provider.rs Tests Unix-socket requests and returned attestation evidence.
crates/​attested-tls/​Cargo.toml Updates the attestation dependency revision.
crates/​attested-tls-proxy/​tests/​provider_cli.rs Tests explicit-type requirements and rejection of the removed flag.
crates/​attested-tls-proxy/​TCP_TUNNEL.md Documents provider options and connection-time errors.
crates/​attested-tls-proxy/​src/​cli/​tcp_tunnel.rs Wires provider socket configuration into TCP tunnel commands.
crates/​attested-tls-proxy/​src/​cli/​http.rs Adds provider options to HTTP and file-server commands.
crates/​attested-tls-proxy/​src/​cli/​attestation.rs Validates provider type selection and extends generator tests.
crates/​attested-tls-proxy/​Cargo.toml Aligns the PCCS dependency revision with upstream.
Cargo.lock Locks updated upstream dependencies and transitive changes.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants