Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The newly pinned attestation dependency is unavailable in this checkout, so provider interoperability, socket validation, and failure handling require human verification.
No open issues 🎉
What changed in this PR
This PR migrates attestation generation to the upstream Unix-socket provider API, allowing the proxy to delegate quote generation and platform metadata collection to a separate local service.
Changes:
- Replaces
--dev-dummy-dcapwith--attestation-provider-socketandATTESTATION_PROVIDER_SOCKETacross all five supported commands. - Requires an explicit local attestation type when using a provider, while preserving explicit
nonesupport. - Updates dependencies, adds provider and CLI tests, and documents configuration and migration.
| File | Description |
|---|---|
| README.md | Documents provider configuration, permissions, and migration. |
| crates/attested-tls/tests/attestation_provider.rs | Tests Unix-socket requests and returned attestation evidence. |
| crates/attested-tls/Cargo.toml | Updates the attestation dependency revision. |
| crates/attested-tls-proxy/tests/provider_cli.rs | Tests explicit-type requirements and rejection of the removed flag. |
| crates/attested-tls-proxy/TCP_TUNNEL.md | Documents provider options and connection-time errors. |
| crates/attested-tls-proxy/src/cli/tcp_tunnel.rs | Wires provider socket configuration into TCP tunnel commands. |
| crates/attested-tls-proxy/src/cli/http.rs | Adds provider options to HTTP and file-server commands. |
| crates/attested-tls-proxy/src/cli/attestation.rs | Validates provider type selection and extends generator tests. |
| crates/attested-tls-proxy/Cargo.toml | Aligns the PCCS dependency revision with upstream. |
| Cargo.lock | Locks updated upstream dependencies and transitive changes. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
attestationcrate to use the merged Unix-socket provider API.It replaces the
--dev-dummy-dcapcommand line option with--attestation-provider-socketorATTESTATION_PROVIDER_SOCKET.If a provider is used, an explicit local attestation type must be given - as platform detection is not possible due to permissions.