Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a live password requirements checklist to the sign-up screen based on the project's password policy. It adds a new PasswordRequirementsChecklist composable to display met and unmet requirements dynamically as the user types, and integrates it with local validation rules to avoid redundant error messages. Additionally, comprehensive unit tests are added in SignUpUIPasswordPolicyTest and SignUpUITest to verify the checklist's behavior, error handling, and configuration swaps. There are no review comments, so we have no feedback to provide.
demolaf
force-pushed
the
auth/password-policy-checklist
branch
from
November 5, 2026 15:14
47b6de7 to
f7a4550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows the project password policy as a live checklist under the sign-up password field, behind an internal switch that stays off until the public opt-in flag lands.
Changes
ENFORCE, and localpasswordValidationRuleskeep blocking as before.minimumPasswordLengthlike the submit path does, so the button stays disabled below the minimum instead of failing on submit.Maintainer note: Part of internal CPRN-449