Skip to content

Fix case where Plug.Conn.Adapter.upgrade/3 could return any error tuple - #1340

Merged
josevalim merged 1 commit into
elixir-plug:mainfrom
mtrudel:upgrade_adapter_error_handling
Nov 4, 2026
Merged

josevalim merged 1 commit into
elixir-plug:mainfrom
mtrudel:upgrade_adapter_error_handling

Conversation

@mtrudel

@mtrudel mtrudel commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Discovered in the course of implementing phoenixframework/websock_adapter#30. Previously we were throwing a CaseError

@josevalim
josevalim merged commit 0d5b5ea into elixir-plug:main Nov 4, 2026
2 checks passed
@mtrudel
mtrudel deleted the upgrade_adapter_error_handling branch November 4, 2026 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants