Repository navigation
Make Enum.slide match the semantics of Enum.slice and reduce traversals of the list - #16157
Merged
Merged
Conversation
Contributor
Author
|
I was actually much in doubt about the anonymous function. Would you like to put a comment on it? So I can learn for future reference. If not it's also fine I have an idea why 😊 |
Member
|
Nothing wrong with having it but I personally didn't think the indirection was worth it for something that happens twice. Three times I'd agree :D |
Contributor
Author
|
Thank you ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16156
Changes
insertion_indexto 0 to avoid retraversing the list linear to the indexEnum.slidematch the behavior ofEnum.sliceThis PR is linked to the issues outlined in the issue I just submitted.