Repository navigation
Fix @spec mismatches and remove unused private-function parameters - #4817
Merged
Merged
Conversation
Member
|
Thank y8ou @manuel-rubio! The fixes are welcome but we don't plan to add a new dependency for now. So can you please remove it and the PLTX? Thanks! |
Contributor
Author
Done. You're welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated to keep only the
@specfixes and unused private-function parameter cleanups (without adding any dependency or.ppltartifact).Summary of Changes
Typespec fixes (
@specvs implementation):Ecto.Query.Builder.From.build/5(lib/ecto/query/builder/from.ex): widenasspec fromatomtoatom | Macro.t()(macro calls pass{:^, _, [as]}).Ecto.Query.Builder.Join.build/10(lib/ecto/query/builder/join.ex): widenasspec fromatomtoatom | Macro.t().Ecto.Repo.Assoc.query/4(lib/ecto/repo/assoc.ex): fix return spec from[Ecto.Schema.t]to[list](matching all clauses andEcto.Repo.Preloader.query/7).Unused private-function parameters removed without changing any public API:
Ecto.Multi.apply_operation/4->/3(lib/ecto/multi.ex): drop unused_apply_argsacross all 7 clauses (and mark_wrapinapply_operation/5).Ecto.Query.Builder.Windows.build_runtime_window/2->/1(lib/ecto/query/builder/windows.ex): drop unused_env.Ecto.Changeset.put_relation/5->/4(lib/ecto/changeset.ex): drop unused_opts(publicput_assoc/4andput_embed/4signatures unchanged).Ecto.Repo.Preloader.maybe_pmap/3->/2(lib/ecto/repo/preloader.ex): drop unused_repo_name.Ecto.Repo.Schema(lib/ecto/repo/schema.ex): drop unused_namein privatedo_insert_all/7->/6,do_insert/4->/3, anddo_update/4->/3(publicinsert_all/5,insert/4,update/4signatures unchanged).Verification
mix test: 1649 passed (97 doctests, 1552 tests).