Skip to content

Windows splash screen and shared AppUserModelID - #21

Merged
dominicletz merged 5 commits into
masterfrom
shared-app-user-model-id
Nov 18, 2026
Merged

dominicletz merged 5 commits into
masterfrom
shared-app-user-model-id

Conversation

@dominicletz

@dominicletz dominicletz commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Host-first Windows splash with optional [ui] splash_icon / --edw-splash-icon (PE icon fallback), Starting/Repairing/Restarting status, dismiss on first window.open
  • Tray left- and right-click both open the bound context menu
  • Shared AppUserModelID so Task Manager groups host and BEAM (EDW_APP_USER_MODEL_ID + Windows NIF)

Test plan

  • Build Windows host; packaged-style launch shows splash logo from --edw-splash-icon
  • --edw-no-beam does not show splash
  • Tray left-click opens the same menu as right-click
  • Host + BEAM share AppUserModelID / group in Task Manager when identifier is set

Made with Cursor


Note

Medium Risk
Touches Windows startup (splash, BEAM respawn paths), process identity for Shell/notifications, and a new native NIF build path on Windows; Transport lifecycle change affects test/subscription races.

Reviewed by Cursor Bugbot for commit 2f6baf1. Configure here.

dominicletz and others added 3 commits November 18, 2026 02:01
Packaged host-first boots show an optional splash logo from [ui] splash_icon (or --edw-splash-icon) with Starting/Repairing/Restarting status, and tray left-click opens the same menu as right-click. Host and BEAM share package.identifier via AppUserModelID so Task Manager groups them.

Co-authored-by: Cursor <cursoragent@cursor.com>
Killing EventBridge in unit tests was taking Transport with it via start_link, so the next subscribe could race a dead process and fail quit/event tests.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2f6baf1. Configure here.

Comment thread lib/desktop_webview/transport.ex Resolved
dominicletz and others added 2 commits November 18, 2026 07:14
Transport stays unlinked so EventBridge test kills do not race a dead name; EventBridge now monitors Transport and re-attaches so host events keep flowing.

Co-authored-by: Cursor <cursoragent@cursor.com>
MinGW make of the NIF fails on Windows CI against OTP headers; produce aumid_nif.dll next to the host in build_windows.ps1. Also make the splash borderless with CS_DROPSHADOW and a gray background.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dominicletz
dominicletz merged commit 0d493d0 into master Nov 18, 2026
4 checks passed
@dominicletz
dominicletz deleted the shared-app-user-model-id branch November 18, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant