Repository navigation
Windows splash screen and shared AppUserModelID - #21
Merged
Merged
Conversation
Packaged host-first boots show an optional splash logo from [ui] splash_icon (or --edw-splash-icon) with Starting/Repairing/Restarting status, and tray left-click opens the same menu as right-click. Host and BEAM share package.identifier via AppUserModelID so Task Manager groups them. Co-authored-by: Cursor <cursoragent@cursor.com>
Killing EventBridge in unit tests was taking Transport with it via start_link, so the next subscribe could race a dead process and fail quit/event tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because on-demand usage is turned off. To enable Bugbot Autofix, turn on on-demand usage and set a spend limit in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2f6baf1. Configure here.
Transport stays unlinked so EventBridge test kills do not race a dead name; EventBridge now monitors Transport and re-attaches so host events keep flowing. Co-authored-by: Cursor <cursoragent@cursor.com>
MinGW make of the NIF fails on Windows CI against OTP headers; produce aumid_nif.dll next to the host in build_windows.ps1. Also make the splash borderless with CS_DROPSHADOW and a gray background. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
[ui] splash_icon/--edw-splash-icon(PE icon fallback), Starting/Repairing/Restarting status, dismiss on firstwindow.openEDW_APP_USER_MODEL_ID+ Windows NIF)Test plan
--edw-splash-icon--edw-no-beamdoes not show splashMade with Cursor
Note
Medium Risk
Touches Windows startup (splash, BEAM respawn paths), process identity for Shell/notifications, and a new native NIF build path on Windows; Transport lifecycle change affects test/subscription races.
Reviewed by Cursor Bugbot for commit 2f6baf1. Configure here.