Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
streamQueryran a streaming query wheneverstreamwas set, even tofalse, and couldn't decode results withUtf8Viewcolumns, which Amp returns for casts toVARCHAR. It now only sendsamp-streamforstream: true, and decodesUtf8ViewandBinaryView: the schema parser knows both types, record batches read their variadic buffer counts, and new readers handle inline and out-of-line values.stream: falseran a streaming query that never ended. It now runs a normal query.Utf8Viewcolumn (likeCAST(x AS VARCHAR)orconcat) failed withParseSchemaError(InvalidArrowDataTypeError, type 24), andBinaryViewones with type 23. Both now decode.You might prefer:
amp-stream: falseforstream: false, instead of leaving the header out.ListView,LargeListViewandRunEndEncodedstill fail withInvalidArrowDataTypeError.decodeDictionaryBatch.streamQuerydoesn't decode dictionary batches yet (the TODO inservice.ts), so I left it.Checks:
pnpm lint,pnpm check:tsgo,pnpm test(237 passed, 4 new) andpnpm circularpass.amp-streamheader forstream: falseandtrue, and roundtripUtf8ViewandBinaryViewcolumns, including nested ones and values spread over several data buffers. They fail without the fix.stream: falseends with all rows, andstream: truestill streams.CAST(block_num AS VARCHAR),concat(long and short values, nulls) andarrow_cast(…, 'BinaryView')all decode and match their source columns.Fixes #32
🤖 Generated with Claude Code