Repository navigation
Make unified diff tests robust in nightly SDKs - #3071
tobiasmelcher merged 1 commit into
Conversation
|
Thanks @iloveeclipse for reporting the test failures! I was now able to reproduce them locally as well by running the tests against the downloaded nightly SDK. Do the additions to AGENTS.md make sense to you? The goal is to help other contributors, working with an agent, find the matching nightly build and reproduce its test failures locally, including cases where the scoped Maven test run behaves differently. |
d8658a4 to
0287b6d
Compare
Could you please remove this change and propose dedicated PR with this? I saw many discussions regarding the content of the AGENTS file and I don't want mix the fix of the problem with unrelated change which might trigger another controversial comments. I personally have no opinion on that particular file content, due lack of time :-) |
Close Welcome and assert a visible, non-empty editor before paint-dependent tests. Preserve footer border coverage after disposal with native-zoom pixel checks and detailed failure diagnostics. Fixes eclipse-platform#3069
0287b6d to
8a861b6
Compare
|
Thanks @iloveeclipse, that makes sense. I’ve removed the AGENTS.md changes from this PR. |
Close Welcome before opening the editor and assert that its widget is visible with a non-empty client area, avoiding misleading paint failures in a full SDK. Preserve the footer border check when disposal happens during drawing by sampling at native zoom with the existing RGB tolerance and detailed failure diagnostics.
Fixes #3069