Skip to content

Make unified diff tests robust in nightly SDKs - #3071

Merged
tobiasmelcher merged 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/unified-diff-nightly-tests
Nov 12, 2026
Merged

tobiasmelcher merged 1 commit into
eclipse-platform:masterfrom
tobiasmelcher:d031119/unified-diff-nightly-tests

Conversation

@tobiasmelcher

@tobiasmelcher tobiasmelcher commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Close Welcome before opening the editor and assert that its widget is visible with a non-empty client area, avoiding misleading paint failures in a full SDK. Preserve the footer border check when disposal happens during drawing by sampling at native zoom with the existing RGB tolerance and detailed failure diagnostics.

Fixes #3069

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Test Results

    54 files  ±0      54 suites  ±0   40m 43s ⏱️ + 2m 20s
 5 022 tests ±0   5 000 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 957 runs  ±0  12 803 ✅ ±0  154 💤 ±0  0 ❌ ±0 

Results for commit 8a861b6. ± Comparison against base commit 6c1a527.

♻️ This comment has been updated with latest results.

@tobiasmelcher

Copy link
Copy Markdown
Contributor Author

Thanks @iloveeclipse for reporting the test failures! I was now able to reproduce them locally as well by running the tests against the downloaded nightly SDK.

Do the additions to AGENTS.md make sense to you? The goal is to help other contributors, working with an agent, find the matching nightly build and reproduce its test failures locally, including cases where the scoped Maven test run behaves differently.

@tobiasmelcher
tobiasmelcher force-pushed the d031119/unified-diff-nightly-tests branch from d8658a4 to 0287b6d Compare November 12, 2026 12:57
@iloveeclipse

Copy link
Copy Markdown
Member

Do the additions to AGENTS.md make sense to you? The goal is to help other contributors, working with an agent, find the matching nightly build and reproduce its test failures locally, including cases where the scoped Maven test run behaves differently.

Could you please remove this change and propose dedicated PR with this? I saw many discussions regarding the content of the AGENTS file and I don't want mix the fix of the problem with unrelated change which might trigger another controversial comments. I personally have no opinion on that particular file content, due lack of time :-)

Close Welcome and assert a visible, non-empty editor before paint-dependent tests. Preserve footer border coverage after disposal with native-zoom pixel checks and detailed failure diagnostics.

Fixes eclipse-platform#3069
@tobiasmelcher
tobiasmelcher force-pushed the d031119/unified-diff-nightly-tests branch from 0287b6d to 8a861b6 Compare November 12, 2026 14:37
@tobiasmelcher

Copy link
Copy Markdown
Contributor Author

Thanks @iloveeclipse, that makes sense. I’ve removed the AGENTS.md changes from this PR.

@tobiasmelcher
tobiasmelcher merged commit 30dafa8 into eclipse-platform:master Nov 12, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnifiedDiffManagerTest.testRevertingEarlierDiffRefreshesRemainingCodeMiningPosition fails since I20261111-2300

2 participants