Repository navigation
[minor] ButtonLink implementation - #2594
PelayoFelgueroso wants to merge 13 commits into
Conversation
There was a problem hiding this comment.
Since all tests are the same scenarios with different props we can merge them into a function that returns the buttons.
There was a problem hiding this comment.
should we do the same at the Button component? And probably to other components too?
| <Title title="Visited" theme="light" level={4} /> | ||
| <DxcFlex> | ||
| <ExampleContainer pseudoState="pseudo-visited"> | ||
| <DxcButtonLink href="#not-visited" label="Button Link" mode="primary" /> |
There was a problem hiding this comment.
A bit confusing to use href "#not-visited" for the visited tests. Nothing serious but I would prefer to change this to avoid confusions.
There was a problem hiding this comment.
Just this component is fine. That way we reduce the scope of the PR to just the button link component.
| /> | ||
| </ExampleContainer> | ||
| </DxcFlex> | ||
| <Title title="Large" theme="light" level={2} /> |
There was a problem hiding this comment.
Isn't this scenario covered by the default button?
There was a problem hiding this comment.
Can we increase a bit more the coverage of the component?
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Implement ButtonLink component based on the design and add documentation to the site.