Skip to content

Move CI and local work to Bun 1.4.5 #806

Open

Description

@HMarzban

What

Move CI and local work from Bun 1.4.4 to 1.4.5 (released 2026-11-19). Maintainer request, 2026-11-21.

Why

  • Security. The 1.4.5 release notes say it "includes security fixes for HTTP/3, TLS and DNS". They name no CVE or GHSA id. The fixes come from newer BoringSSL (November 2026), c-ares 1.34.9, llhttp 9.4.4, lsquic 4.11.2 and SQLite 3.54.1. Our servers use TLS, DNS and fetch on every request to Supabase and on every link-metadata fetch.
  • Production already runs it. The images start from the floating oven/bun:1-slim tag (Run CI on Bun 1.4.4, the version production ships #650). The deploy of 2026-11-21 12:48Z pulled 1.4.5, and its compare step warned: Image runs Bun 1.4.5; CI tests 1.4.4. So CI tests a different Bun from the one production runs.

Risk check (from the release notes)

  • Stricter checks on custom root certificates: the app code sets no custom CA. Prisma's production connection uses rejectUnauthorized: false, which this does not touch.
  • SQLite 3.54 changes: no bun:sqlite use in the repo.
  • No WebSocket, bun install, bun.lock or bun test change is listed.

Plan

  1. Set the CI pin to 1.4.5 in .github/actions/setup-bun/action.yml and .github/workflows/lockstep-guard.yml.
  2. Update the one doc that names the CI version as current (apps/webapp/cypress/e2e/chatroom/README.md), and add a changelog line.
  3. Leave the Dockerfiles on oven/bun:1-slim, as Run CI on Bun 1.4.4, the version production ships #650 decided. They already run 1.4.5.
  4. Leave notes that record a measurement made on 1.4.4 as they are. They are true for that run.

Checks

Activity

  1. added this to the v2.3.7 milestone on Nov 21, 2026
  2. HMarzban commented on Nov 21, 2026

    @HMarzban
    CollaboratorAuthor

    Review and local checks, 2026-11-21

    Independent review: plan OK. It kept the scope to the two CI pins, one README line and one root changelog line:

    • bun-types stays ^1.4.4. It holds type declarations only, so it carries none of the security fixes. The next bun run update sweep moves it after the 3-day hold. A hold exclude is for urgent security bumps.
    • engines.bun stays >=1.4.0. That is the floor, not the CI pin.
    • The comments that name 1.4.4 behaviour stay. CI already tests that behaviour: e2e-versions.ts section [8] checks that a 17 MiB message closes with 1009.
    • The setup-bun cache key includes the Bun version, so the cache resets on its own.

    Local checks on Bun 1.4.5 (Apple M5 Max): bun run test:unit passed. That covers 6 extension Cypress suites (25, 26, 34, 123, 289 and 270 specs), Bun tests (530 and 14), and webapp Jest (540 tests in 71 suites). bun run typecheck passed.

    Benchmarks. The #726 and #704 befores ran on 1.4.4. Their afters will run on a kept 1.4.4 binary (checksum checked against the release's SHASUMS256.txt), and each after will name it.

  3. HMarzban commented on Nov 21, 2026

    @HMarzban
    CollaboratorAuthor

    Committed as 2212dc306 (ci: move the Bun pin to 1.4.5), 4 files. Not pushed yet. The first push runs CI on 1.4.5.

  4. added a commit that references this issue on Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions