Repository navigation
update to debian trixie - #7486
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
thaJeztah
force-pushed
the
bump_trixie
branch
2 times, most recently
from
November 5, 2026 21:54
39010e1 to
fb5ac24
Compare
docker-agent
reviewed
Nov 5, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
There was a problem hiding this comment.
🟡 Changes recommended
Debian cross-builds fail because xx-apt-get cannot resolve the virtual libgcc-dev package to an installable target-architecture provider.
1 open issue
What changed in this PR
Updates the Docker CLI’s Debian build environment from Bookworm to Trixie, building on the Alpine 3.24 update in #7485.
Changes:
- Sets Trixie as the default Debian base and adds a comment describing the build argument.
- Replaces the version-specific
libgcc-12-devdependency withlibgcc-dev.
| File | Description |
|---|---|
| Dockerfile | Updates the Debian base and GCC development dependency for Debian builds. |
Review effort: Balanced
docker-agent
reviewed
Nov 5, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
docker-agent
reviewed
Nov 5, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
bump_trixie
branch
from
November 5, 2026 22:29
fb5ac24 to
a0f7df6
Compare
thaJeztah
requested review from
docker-agent
and
a balanced review from Copilot
November 5, 2026 22:29
vvoland
approved these changes
Nov 5, 2026
docker-agent
reviewed
Nov 5, 2026
docker-agent
left a comment
docker-agent
left a comment
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)