Repository navigation
fix: preserve Prime layout contracts and require Figma-backed completion - #119
Merged
owjs3901 merged 8 commits intoNov 6, 2026
Conversation
added 8 commits
November 6, 2026 01:57
owjs3901
marked this pull request as ready for review
November 6, 2026 04:31
owjs3901
deleted the
devfive/3099154426bffbeef8b62999b80bb038/prime-feedback-layout-and-validation
branch
November 6, 2026 04:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prime exports could lose caller FILL allocation when a component was detached, while a 16x16 absolute rectangle became an unsized, parent-height box. Preserve selected-root sizing and instance HUG alignment, retain measured non-fluid rectangle dimensions, and expose unapplied reference sizing as a placement contract. Preserve existing full-parent overlay relationships. The compiled-browser regression checks 420px title / 40px gap / 520px card geometry and native Figma marker paint, with wrong-colour and wrong-shape controls.
Make pageScaffold emit the actual generated body directly in app/**/page.tsx. Correct all shipped frontend workflow entry points and examples: components/pages contains page-local partials; every application request uses devup-api; update/reproduce missing capabilities, document a feature request and stop affected work while continuing independent work.
Application completion now requires separately observed functional e2e command evidence and server-recomputed comparisons against native Figma artifacts. Missing/inconclusive references, changed screenshots, local replacement baselines and incomplete renderer evidence remain unverified. Diagnosis retries include code/map/theme dependencies. Keep export summaries under the existing 15KiB budget and isolate integration fixtures for parallel execution, including private asset registries; preserve production collision guards.
A running project is not a desktop-wide lock. Bootstrap instructions, the usage guide, Bridge setup and all frontend entry points now require OS split-screen with separate project windows, ports and browser contexts. Verify window/file identity before input, coordinate only conflicting input batches, retain other running projects and preserve visual-test viewport/DPR/zoom. Actual tool locks remain scoped to the affected operation. The user confirmed split-screen feasibility; this documentation update does not claim a new live GUI experiment.
Feedback audit: all 31 records, fixes and remaining scope. Remaining work includes the generator's earlier Korean keep-all heuristic and separately scoped compositor/compiler/watcher concerns. Four reviewed code goldens and their checksums change; the native Figma reference is preserved. Includes a patch changepack.
Validation:
Submitted via Devfive hub.
Employee Git identity (self-declared): <>
Device:
3099154426bffbeef8b62999b80bb038