Skip to content

Fix u32 codec and add i32, i64, and bool - #5

Merged
cowlicks merged 2 commits into
datrs:mainfrom
kasperisager:fix-u32-add-i32-i64-bool
Nov 5, 2026
Merged

cowlicks merged 2 commits into
datrs:mainfrom
kasperisager:fix-u32-add-i32-i64-bool

Conversation

@kasperisager

Copy link
Copy Markdown
Contributor

No description provided.

@ttiurani

ttiurani commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

Thanks! On the surface this looks solid, but I unfortunately don't have my rust setup up to release this so will need @cowlicks to merge.

@cowlicks cowlicks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm excited to see some interest in this! Thank you for catching this bug, and for adding these new impls. I have one small comment about the error message, and a request to make a change to my own code 😅😅.

p.s. I'm curious what you're using this for, if you are able to share.

Comment thread src/lib.rs Resolved
Comment thread src/lib.rs Resolved
@cowlicks

cowlicks commented Nov 4, 2026

Copy link
Copy Markdown
Member

After releasing v2.2.0 I hadn't pushed the release from my user repo to the datrs one. I just pushed that. So you should rebase and move the stuff added in the CHANGELOG.md into "Unreleased" section. Sorry about that!

@kasperisager

kasperisager commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor Author

Happy to help! We're working on expanding our non-JavaScript language support for https://github.com/holepunchto/bare-kit using https://github.com/holepunchto/bare-rpc to communicate between JavaScript and the host language. To that end we're implementing bare-rpc-<lang> and, since it's based on compact-encoding, compact-encoding-<lang> variants for the various languages we're looking to support. Since you folks were already working on the Rust variant and held https://crates.io/crates/compact-encoding I decided to add the bits missing for bare-rpc.

@cowlicks
cowlicks merged commit 8f22dd3 into datrs:main Nov 5, 2026
6 checks passed
@cowlicks

cowlicks commented Nov 5, 2026

Copy link
Copy Markdown
Member

Thank you @kasperisager I'll cut a release today.

@cowlicks

cowlicks commented Nov 5, 2026

Copy link
Copy Markdown
Member

@kasperisager New version published: https://crates.io/crates/compact-encoding/2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants