Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model validation drops numeric zero and boolean false from additional parameters, so the configuration checked can differ from the configuration used at runtime. Replace the truthiness filter with explicit missing/empty-string checks, preserving zero, false and supplied empty containers while continuing to skip empty keys, None and empty strings.
Fixes #1446.
Validation:
This concerns typed API/configuration values; manually typing "0" into the current text input produces a string and does not reproduce the zero-value case. No live authenticated HTTP route, database, browser or external LLM was exercised. The existing LLMConfig Pydantic deprecation warnings remain.