Repository navigation
ja: write 角 as かく and 循環節 as 循環せつ, which Open JTalk misread - #1069
Open
yasumorishima wants to merge 1 commit into
Open
yasumorishima wants to merge 1 commit into
yasumorishima wants to merge 1 commit into
Conversation
角 before a pause was read スミ (∠ABC = 90°) and 循環節 was read ジュンカンブシ. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxieePCjMFcCuuczCmhyB3
Contributor
Linux library size: 0.60 MiB (0.00%)
Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two verified ja words are read wrongly by Open JTalk. 角, the angle word used for ∠ and for measure of angle, is read スミ (corner) when a pause follows it, so ∠ABC = 90° with the letters not grouped, from the zh-cn tests (#1056), started スミ. 循環節 for a repeating decimal is read ジュンカンブシ. They are now written かく and 循環せつ, which are read カク and ジュンカンセツ in every form I tried, the same way 行 is already written ぎょう in the matrix rules. Two MathType names in unicode-full.yaml also ended in a lone 角 and had the same problem: U+EA2C (not vert angle) now ends in かく, and U+EC92 (synthetic division corner) is 組立除法 隅, like the corner brackets ⌜ 左上隅. This changes the expected text of the existing angle and repeating-decimal tests, and a new test covers ∠ before a pause and the two MathType names. All tests pass, and audit-translations ja shows two fewer untranslated strings with the other counts unchanged.