Skip to content

ja: write 角 as かく and 循環節 as 循環せつ, which Open JTalk misread - #1069

Open
yasumorishima wants to merge 1 commit into
daisy:mainfrom
yasumorishima:ja-kaku-junkan
Open

yasumorishima wants to merge 1 commit into
daisy:mainfrom
yasumorishima:ja-kaku-junkan

Conversation

@yasumorishima

Copy link
Copy Markdown
Contributor

Two verified ja words are read wrongly by Open JTalk. 角, the angle word used for ∠ and for measure of angle, is read スミ (corner) when a pause follows it, so ∠ABC = 90° with the letters not grouped, from the zh-cn tests (#1056), started スミ. 循環節 for a repeating decimal is read ジュンカンブシ. They are now written かく and 循環せつ, which are read カク and ジュンカンセツ in every form I tried, the same way 行 is already written ぎょう in the matrix rules. Two MathType names in unicode-full.yaml also ended in a lone 角 and had the same problem: U+EA2C (not vert angle) now ends in かく, and U+EC92 (synthetic division corner) is 組立除法 隅, like the corner brackets ⌜ 左上隅. This changes the expected text of the existing angle and repeating-decimal tests, and a new test covers ∠ before a pause and the two MathType names. All tests pass, and audit-translations ja shows two fewer untranslated strings with the other counts unchanged.

角 before a pause was read スミ (∠ABC = 90°) and 循環節 was read ジュンカンブシ.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PxieePCjMFcCuuczCmhyB3
@github-actions

Copy link
Copy Markdown
Contributor
Linux library size: 0.60 MiB (0.00%)
Revision Release liblibmathcat.so
Base (e382c55) 0.60 MiB (625,032 bytes)
PR (64cd200) 0.60 MiB (625,032 bytes)
Change 0 bytes (0.00%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant